Re: [PATCH] iosys-map: Add word-sized reads

On Mon, Jun 13, 2022 at 12:58:52PM +0200, Thomas Zimmermann wrote: Hi Lucas Am 10.06.22 um 01:20 schrieb Lucas De Marchi: Instead of always falling back to memcpy_fromio() for any size, prefer using read{b,w,l}(). When reading struct members it's common to read individual integer variables indi

Re: [PATCH] iosys-map: Add word-sized reads

Hi Lucas Am 10.06.22 um 01:20 schrieb Lucas De Marchi: Instead of always falling back to memcpy_fromio() for any size, prefer using read{b,w,l}(). When reading struct members it's common to read individual integer variables individually. Going through memcpy_fromio() for each of them poses a hig

Re: [PATCH] iosys-map: Add word-sized reads

On Fri, Jun 10, 2022 at 09:20:18AM +0200, Christian König wrote: Am 10.06.22 um 01:20 schrieb Lucas De Marchi: Instead of always falling back to memcpy_fromio() for any size, prefer using read{b,w,l}(). When reading struct members it's common to read individual integer variables individually. Go

Re: [PATCH] iosys-map: Add word-sized reads

Hi Lucas, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on linus/master v5.19-rc1 next-20220610] [cannot apply to tegra-drm/drm/tegra/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when s

Re: [PATCH] iosys-map: Add word-sized reads

Am 10.06.22 um 01:20 schrieb Lucas De Marchi: Instead of always falling back to memcpy_fromio() for any size, prefer using read{b,w,l}(). When reading struct members it's common to read individual integer variables individually. Going through memcpy_fromio() for each of them poses a high penalty.

Re: [PATCH] iosys-map: Add word-sized reads

Hi Lucas, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on linus/master v5.19-rc1 next-20220609] [cannot apply to tegra-drm/drm/tegra/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when s

[PATCH] iosys-map: Add word-sized reads

Instead of always falling back to memcpy_fromio() for any size, prefer using read{b,w,l}(). When reading struct members it's common to read individual integer variables individually. Going through memcpy_fromio() for each of them poses a high penalty. Employ a similar trick as __seqprop() by using