[PATCH] i915: Remove silly test

2012-07-26 Thread Daniel Vetter
On Wed, Jul 25, 2012 at 01:51:20PM +0100, Alan Cox wrote: > From: Alan Cox > > drv_priv->gmbus is an array. Comparing it with NULL is somewhat less useful > than a chocolate teapot. > > Possibly we should be testing bus != NULL each iteration of the loop > instead ? > > gcc could help by warnin

Re: [PATCH] i915: Remove silly test

2012-07-26 Thread Daniel Vetter
On Wed, Jul 25, 2012 at 01:51:20PM +0100, Alan Cox wrote: > From: Alan Cox > > drv_priv->gmbus is an array. Comparing it with NULL is somewhat less useful > than a chocolate teapot. > > Possibly we should be testing bus != NULL each iteration of the loop > instead ? > > gcc could help by warnin

[PATCH] i915: Remove silly test

2012-07-25 Thread Alan Cox
From: Alan Cox drv_priv->gmbus is an array. Comparing it with NULL is somewhat less useful than a chocolate teapot. Possibly we should be testing bus != NULL each iteration of the loop instead ? gcc could help by warning too! Signed-off-by: Alan Cox --- drivers/gpu/drm/i915/intel_i2c.c |

[PATCH] i915: Remove silly test

2012-07-25 Thread Alan Cox
From: Alan Cox drv_priv->gmbus is an array. Comparing it with NULL is somewhat less useful than a chocolate teapot. Possibly we should be testing bus != NULL each iteration of the loop instead ? gcc could help by warning too! Signed-off-by: Alan Cox --- drivers/gpu/drm/i915/intel_i2c.c |