Re: [PATCH] i915: Quirk out disconnected backlight

2012-09-18 Thread Grant Likely
On Mon, Sep 17, 2012 at 9:03 AM, Jani Nikula wrote: > Hi Grant, please try v3.6-rc6 that does exactly that with: > > commit 28dcc2d60cb570d9f549c329b2f51400553412a1 > Author: Jani Nikula > Date: Mon Sep 3 16:25:12 2012 +0300 > > drm/i915: do not expose a dysfunctional backlight interface to

[PATCH] i915: Quirk out disconnected backlight

2012-09-17 Thread Grant Likely
On Mon, Sep 17, 2012 at 9:03 AM, Jani Nikula wrote: > Hi Grant, please try v3.6-rc6 that does exactly that with: > > commit 28dcc2d60cb570d9f549c329b2f51400553412a1 > Author: Jani Nikula > Date: Mon Sep 3 16:25:12 2012 +0300 > > drm/i915: do not expose a dysfunctional backlight interface to

[PATCH] i915: Quirk out disconnected backlight

2012-09-17 Thread Jani Nikula
On Fri, 14 Sep 2012, Grant Likely wrote: > On Fri, Sep 14, 2012 at 2:12 PM, David Woodhouse > wrote: >> See https://bugzilla.redhat.com/show_bug.cgi?id=752595 > > In that bug you mention that the intel backlight sets a bogus max of > '1' when a backlight isn't present. I saw that too here. Here'

Re: [PATCH] i915: Quirk out disconnected backlight

2012-09-17 Thread Jani Nikula
On Fri, 14 Sep 2012, Grant Likely wrote: > On Fri, Sep 14, 2012 at 2:12 PM, David Woodhouse wrote: >> See https://bugzilla.redhat.com/show_bug.cgi?id=752595 > > In that bug you mention that the intel backlight sets a bogus max of > '1' when a backlight isn't present. I saw that too here. Here's t

Re: [PATCH] i915: Quirk out disconnected backlight

2012-09-15 Thread Grant Likely
On Fri, Sep 14, 2012 at 2:12 PM, David Woodhouse wrote: > On Fri, 2012-09-14 at 14:09 +0100, Grant Likely wrote: >> On Fri, Sep 14, 2012 at 2:01 PM, Chris Wilson >> wrote: >> > On Fri, 14 Sep 2012 13:57:06 +0100, Grant Likely >> > wrote: >> >> Some platforms (for instance MacbookPros) have cus

[PATCH] i915: Quirk out disconnected backlight

2012-09-15 Thread Grant Likely
Some platforms (for instance MacbookPros) have custom backlight drivers and don't use the integrated i915 backlight control. This patch adds a quirk to disable registering the intel backlight when unused on a platform. Tested on MacbookPro8,3. Without this patch both the intel_backlight and gmux_b

Re: [PATCH] i915: Quirk out disconnected backlight

2012-09-15 Thread Grant Likely
On Fri, Sep 14, 2012 at 2:01 PM, Chris Wilson wrote: > On Fri, 14 Sep 2012 13:57:06 +0100, Grant Likely > wrote: >> Some platforms (for instance MacbookPros) have custom backlight drivers >> and don't use the integrated i915 backlight control. This patch adds a >> quirk to disable registering th

[PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread Matthew Garrett
On Fri, Sep 14, 2012 at 03:29:14PM +0100, David Woodhouse wrote: > On Fri, 2012-09-14 at 14:48 +0100, Matthew Garrett wrote: > > On Fri, Sep 14, 2012 at 01:57:06PM +0100, Grant Likely wrote: > > > > > Tested on MacbookPro8,3. Without this patch both the intel_backlight and > > > gmux_backlight dev

[PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread David Woodhouse
On Fri, 2012-09-14 at 14:48 +0100, Matthew Garrett wrote: > On Fri, Sep 14, 2012 at 01:57:06PM +0100, Grant Likely wrote: > > > Tested on MacbookPro8,3. Without this patch both the intel_backlight and > > gmux_backlight devices get registered and userspace doesn't know which > > it should use. >

[PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread Matthew Garrett
On Fri, Sep 14, 2012 at 01:57:06PM +0100, Grant Likely wrote: > Tested on MacbookPro8,3. Without this patch both the intel_backlight and > gmux_backlight devices get registered and userspace doesn't know which > it should use. Userspace should be figuring out which one to use from the type field.

[PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread Chris Wilson
On Fri, 14 Sep 2012 14:12:19 +0100, David Woodhouse wrote: > On Fri, 2012-09-14 at 14:09 +0100, Grant Likely wrote: > > On Fri, Sep 14, 2012 at 2:01 PM, Chris Wilson > > wrote: > > > On Fri, 14 Sep 2012 13:57:06 +0100, Grant Likely > > secretlab.ca> wrote: > > >> Some platforms (for instance M

[PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread Grant Likely
On Fri, Sep 14, 2012 at 2:12 PM, David Woodhouse wrote: > On Fri, 2012-09-14 at 14:09 +0100, Grant Likely wrote: >> On Fri, Sep 14, 2012 at 2:01 PM, Chris Wilson >> wrote: >> > On Fri, 14 Sep 2012 13:57:06 +0100, Grant Likely > > secretlab.ca> wrote: >> >> Some platforms (for instance MacbookPro

[PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread David Woodhouse
On Fri, 2012-09-14 at 14:09 +0100, Grant Likely wrote: > On Fri, Sep 14, 2012 at 2:01 PM, Chris Wilson > wrote: > > On Fri, 14 Sep 2012 13:57:06 +0100, Grant Likely > secretlab.ca> wrote: > >> Some platforms (for instance MacbookPros) have custom backlight drivers > >> and don't use the integrat

[PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread Grant Likely
On Fri, Sep 14, 2012 at 2:01 PM, Chris Wilson wrote: > On Fri, 14 Sep 2012 13:57:06 +0100, Grant Likely secretlab.ca> wrote: >> Some platforms (for instance MacbookPros) have custom backlight drivers >> and don't use the integrated i915 backlight control. This patch adds a >> quirk to disable re

[PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread Chris Wilson
On Fri, 14 Sep 2012 13:57:06 +0100, Grant Likely wrote: > Some platforms (for instance MacbookPros) have custom backlight drivers > and don't use the integrated i915 backlight control. This patch adds a > quirk to disable registering the intel backlight when unused on a > platform. > > Tested on

[PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread Grant Likely
Some platforms (for instance MacbookPros) have custom backlight drivers and don't use the integrated i915 backlight control. This patch adds a quirk to disable registering the intel backlight when unused on a platform. Tested on MacbookPro8,3. Without this patch both the intel_backlight and gmux_b

Re: [PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread Matthew Garrett
On Fri, Sep 14, 2012 at 03:29:14PM +0100, David Woodhouse wrote: > On Fri, 2012-09-14 at 14:48 +0100, Matthew Garrett wrote: > > On Fri, Sep 14, 2012 at 01:57:06PM +0100, Grant Likely wrote: > > > > > Tested on MacbookPro8,3. Without this patch both the intel_backlight and > > > gmux_backlight dev

Re: [PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread David Woodhouse
On Fri, 2012-09-14 at 14:48 +0100, Matthew Garrett wrote: > On Fri, Sep 14, 2012 at 01:57:06PM +0100, Grant Likely wrote: > > > Tested on MacbookPro8,3. Without this patch both the intel_backlight and > > gmux_backlight devices get registered and userspace doesn't know which > > it should use. >

Re: [PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread Matthew Garrett
On Fri, Sep 14, 2012 at 01:57:06PM +0100, Grant Likely wrote: > Tested on MacbookPro8,3. Without this patch both the intel_backlight and > gmux_backlight devices get registered and userspace doesn't know which > it should use. Userspace should be figuring out which one to use from the type field.

Re: [PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread Chris Wilson
On Fri, 14 Sep 2012 14:12:19 +0100, David Woodhouse wrote: > On Fri, 2012-09-14 at 14:09 +0100, Grant Likely wrote: > > On Fri, Sep 14, 2012 at 2:01 PM, Chris Wilson > > wrote: > > > On Fri, 14 Sep 2012 13:57:06 +0100, Grant Likely > > > wrote: > > >> Some platforms (for instance MacbookPros)

Re: [PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread David Woodhouse
On Fri, 2012-09-14 at 14:09 +0100, Grant Likely wrote: > On Fri, Sep 14, 2012 at 2:01 PM, Chris Wilson > wrote: > > On Fri, 14 Sep 2012 13:57:06 +0100, Grant Likely > > wrote: > >> Some platforms (for instance MacbookPros) have custom backlight drivers > >> and don't use the integrated i915 bac

Re: [PATCH] i915: Quirk out disconnected backlight

2012-09-14 Thread Chris Wilson
On Fri, 14 Sep 2012 13:57:06 +0100, Grant Likely wrote: > Some platforms (for instance MacbookPros) have custom backlight drivers > and don't use the integrated i915 backlight control. This patch adds a > quirk to disable registering the intel backlight when unused on a > platform. > > Tested on