Re: [PATCH] i2c: at91: use dma safe buffers

2022-04-05 Thread Michael Walle
Am 2022-04-05 15:58, schrieb codrin.ciubota...@microchip.com: On 05.04.2022 14:09, Michael Walle wrote: Am 2022-04-05 12:02, schrieb codrin.ciubota...@microchip.com: On 05.04.2022 12:38, Michael Walle wrote: Am 2022-04-05 11:23, schrieb codrin.ciubota...@microchip.com: +   if (dev->use_dm

Re: [PATCH] i2c: at91: use dma safe buffers

2022-04-05 Thread Michael Walle
Am 2022-04-05 12:02, schrieb codrin.ciubota...@microchip.com: On 05.04.2022 12:38, Michael Walle wrote: Am 2022-04-05 11:23, schrieb codrin.ciubota...@microchip.com: +   if (dev->use_dma) { +   dma_buf = i2c_get_dma_safe_msg_buf(m_start, 1); If you want, you could just dev->bu

Re: [PATCH] i2c: at91: use dma safe buffers

2022-04-05 Thread Michael Walle
Am 2022-04-05 11:23, schrieb codrin.ciubota...@microchip.com: On 03.03.2022 18:17, Michael Walle wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe The supplied buffer might be on the stack and we get the following error message: [3.312058]

Re: [PATCH] i2c: at91: use dma safe buffers

2022-03-28 Thread Michael Walle
Hi all, Am 2022-03-03 17:17, schrieb Michael Walle: The supplied buffer might be on the stack and we get the following error message: [3.312058] at91_i2c e0070600.i2c: rejecting DMA map of vmalloc memory Use i2c_{get,put}_dma_safe_msg_buf() to get a DMA-able memory region if necessary.

Re: [PATCH] i2c: at91: use dma safe buffers

2022-03-04 Thread Christian König
Am 04.03.22 um 09:43 schrieb Wolfram Sang: I'm getting quite a bunch of unrelated mails because the regex is not the best. I can imagine! On the other hand the framework is used in a lot of drivers and I do want to be notified when they mess with their interfaces. Sure thing. I am convinced t

Re: [PATCH] i2c: at91: use dma safe buffers

2022-03-04 Thread Wolfram Sang
> I'm getting quite a bunch of unrelated mails because the regex is not the > best. I can imagine! > On the other hand the framework is used in a lot of drivers and I do want to > be notified when they mess with their interfaces. Sure thing. I am convinced the regex can be improved to ensure th

Re: [PATCH] i2c: at91: use dma safe buffers

2022-03-04 Thread Christian König
Am 04.03.22 um 09:04 schrieb Wolfram Sang: Hi Christian, Maybe call your variable differently. DMA-buf is an inter driver buffer sharing frame we use for GPU acceleration and V4L. It doesn't cause any technical issues, but the maintainer regex now triggers on that. So you are CCing people not

Re: [PATCH] i2c: at91: use dma safe buffers

2022-03-04 Thread Wolfram Sang
Hi Christian, > Maybe call your variable differently. DMA-buf is an inter driver buffer > sharing frame we use for GPU acceleration and V4L. > > It doesn't cause any technical issues, but the maintainer regex now triggers > on that. So you are CCing people not related to this code in any way. Fr

Re: [PATCH] i2c: at91: use dma safe buffers

2022-03-03 Thread Christian König
Am 03.03.22 um 17:17 schrieb Michael Walle: The supplied buffer might be on the stack and we get the following error message: [3.312058] at91_i2c e0070600.i2c: rejecting DMA map of vmalloc memory Use i2c_{get,put}_dma_safe_msg_buf() to get a DMA-able memory region if necessary. Cc: sta...@v

[PATCH] i2c: at91: use dma safe buffers

2022-03-03 Thread Michael Walle
The supplied buffer might be on the stack and we get the following error message: [3.312058] at91_i2c e0070600.i2c: rejecting DMA map of vmalloc memory Use i2c_{get,put}_dma_safe_msg_buf() to get a DMA-able memory region if necessary. Cc: sta...@vger.kernel.org Signed-off-by: Michael Walle -