RE: [PATCH] gpu: drm: radeon: refactor code

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: Koenig, Christian > Sent: Wednesday, May 17, 2017 4:23 AM > To: Gustavo A. R. Silva; Deucher, Alexander; David Airlie > Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > ker...@vger.kernel.org > Subject: Re: [PA

[PATCH] gpu: drm: radeon: refactor code

2017-05-17 Thread Gustavo A. R. Silva
Local variable _color_ is assigned to a constant value and it is never updated again. Remove this variable and refactor the code it affects. Addresses-Coverity-ID: 1226745 Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 8 +--- 1 file changed, 1 inser

Re: [PATCH] gpu: drm: radeon: refactor code

2017-05-17 Thread Christian König
Am 17.05.2017 um 04:20 schrieb Gustavo A. R. Silva: Local variable _color_ is assigned to a constant value and it is never updated again. Remove this variable and refactor the code it affects. Addresses-Coverity-ID: 1226745 Signed-off-by: Gustavo A. R. Silva Mhm, on the one hand it looks like