[PATCH] gma500: define do_gma_backlight_set only when used

2013-09-29 Thread Vincent Stehlé
Make sure static function do_gma_backlight_set() is only defined when CONFIG_BACKLIGHT_CLASS_DEVICE is defined, as it is never called otherwise. This fixes the following warning: drivers/gpu/drm/gma500/backlight.c:29:13: warning: ‘do_gma_backlight_set’ defined but not used [-Wunused-function]

Re: [PATCH] gma500: define do_gma_backlight_set only when used

2013-09-27 Thread Jani Nikula
On Fri, 27 Sep 2013, Patrik Jakobsson wrote: >> +#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE Hi, while at it, you should probably let backlight be built as module: #if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) Cheers, Jani. -- Jani Nikula, Intel Open Source Technology Center __

Re: [PATCH] gma500: define do_gma_backlight_set only when used

2013-09-26 Thread Patrik Jakobsson
On Thu, Sep 26, 2013 at 11:46 PM, Vincent Stehlé wrote: > Make sure static function do_gma_backlight_set() is only defined when > CONFIG_BACKLIGHT_CLASS_DEVICE is defined, as it is never called otherwise. > > This fixes the following warning: > > drivers/gpu/drm/gma500/backlight.c:29:13: warning