[PATCH] gma500: Fix SDVO turning off randomly

2013-08-18 Thread Daniel Vetter
On Fri, Aug 16, 2013 at 02:23:35AM +0200, Patrik Jakobsson wrote: > On Sun, Aug 11, 2013 at 12:00 PM, Daniel Vetter wrote: > > On Sat, Aug 10, 2013 at 10:12 PM, Patrik Jakobsson > > wrote: > > If you take this opportunity to share a bit of code between gma500 and > > i915 (the sdvo #defines heade

Re: [PATCH] gma500: Fix SDVO turning off randomly

2013-08-18 Thread Daniel Vetter
On Fri, Aug 16, 2013 at 02:23:35AM +0200, Patrik Jakobsson wrote: > On Sun, Aug 11, 2013 at 12:00 PM, Daniel Vetter wrote: > > On Sat, Aug 10, 2013 at 10:12 PM, Patrik Jakobsson > > wrote: > > If you take this opportunity to share a bit of code between gma500 and > > i915 (the sdvo #defines heade

[PATCH] gma500: Fix SDVO turning off randomly

2013-08-16 Thread Patrik Jakobsson
On Sun, Aug 11, 2013 at 12:00 PM, Daniel Vetter wrote: > On Sat, Aug 10, 2013 at 10:12 PM, Patrik Jakobsson > wrote: >> I will give this a spin on my gma500 and i915 hardware on monday. The gma500 >> sdvo code should be pretty much identical to i915 from around 2011 but I >> guess >> we've diver

Re: [PATCH] gma500: Fix SDVO turning off randomly

2013-08-15 Thread Patrik Jakobsson
On Sun, Aug 11, 2013 at 12:00 PM, Daniel Vetter wrote: > On Sat, Aug 10, 2013 at 10:12 PM, Patrik Jakobsson > wrote: >> I will give this a spin on my gma500 and i915 hardware on monday. The gma500 >> sdvo code should be pretty much identical to i915 from around 2011 but I >> guess >> we've diver

[PATCH] gma500: Fix SDVO turning off randomly

2013-08-11 Thread Daniel Vetter
On Sat, Aug 10, 2013 at 10:12 PM, Patrik Jakobsson wrote: > I will give this a spin on my gma500 and i915 hardware on monday. The gma500 > sdvo code should be pretty much identical to i915 from around 2011 but I guess > we've diverged since then. I'll also rework sdvo for gma500 a little in the >

Re: [PATCH] gma500: Fix SDVO turning off randomly

2013-08-11 Thread Daniel Vetter
On Sat, Aug 10, 2013 at 10:12 PM, Patrik Jakobsson wrote: > I will give this a spin on my gma500 and i915 hardware on monday. The gma500 > sdvo code should be pretty much identical to i915 from around 2011 but I guess > we've diverged since then. I'll also rework sdvo for gma500 a little in the >

[PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Patrik Jakobsson
On Sat, Aug 10, 2013 at 9:40 PM, Guillaume CL?MENT wrote: >> >> Can you please submit the exact same change for drm/i915/intel_sdvoc.c >> >> too? The sdvo encoders can be the same ones for psb and i915 so having >> >> the same code would be great. Separate patch for drm/i915 ofc. >> > >> > Are yo

[PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Guillaume CLÉMENT
> >> Can you please submit the exact same change for drm/i915/intel_sdvoc.c > >> too? The sdvo encoders can be the same ones for psb and i915 so having > >> the same code would be great. Separate patch for drm/i915 ofc. > > > > Are you absolutely sure that is a hardware error and not a software SDV

Re: [PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Patrik Jakobsson
On Sat, Aug 10, 2013 at 9:40 PM, Guillaume CLÉMENT wrote: >> >> Can you please submit the exact same change for drm/i915/intel_sdvoc.c >> >> too? The sdvo encoders can be the same ones for psb and i915 so having >> >> the same code would be great. Separate patch for drm/i915 ofc. >> > >> > Are you

Re: [PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Guillaume CLÉMENT
> >> Can you please submit the exact same change for drm/i915/intel_sdvoc.c > >> too? The sdvo encoders can be the same ones for psb and i915 so having > >> the same code would be great. Separate patch for drm/i915 ofc. > > > > Are you absolutely sure that is a hardware error and not a software SDV

[PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Daniel Vetter
On Sat, Aug 10, 2013 at 11:19 AM, Chris Wilson wrote: > On Sat, Aug 10, 2013 at 10:55:08AM +0200, Daniel Vetter wrote: >> On Sat, Aug 10, 2013 at 9:06 AM, Guillaume Clement >> wrote: >> > Some Poulsbo cards seem to incorrectly report >> > SDVO_CMD_STATUS_TARGET_NOT_SPECIFIED instead of SDVO_CM

[PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Daniel Vetter
On Sat, Aug 10, 2013 at 9:06 AM, Guillaume Clement wrote: > Some Poulsbo cards seem to incorrectly report > SDVO_CMD_STATUS_TARGET_NOT_SPECIFIED instead of SDVO_CMD_STATUS_PENDING, > which causes the display to be turned off. > > Signed-off-by: Guillaume Clement Can you please submit the exa

[PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Chris Wilson
On Sat, Aug 10, 2013 at 10:55:08AM +0200, Daniel Vetter wrote: > On Sat, Aug 10, 2013 at 9:06 AM, Guillaume Clement > wrote: > > Some Poulsbo cards seem to incorrectly report > > SDVO_CMD_STATUS_TARGET_NOT_SPECIFIED instead of SDVO_CMD_STATUS_PENDING, > > which causes the display to be turned o

[PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Guillaume Clement
Some Poulsbo cards seem to incorrectly report SDVO_CMD_STATUS_TARGET_NOT_SPECIFIED instead of SDVO_CMD_STATUS_PENDING, which causes the display to be turned off. Signed-off-by: Guillaume Clement --- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Daniel Vetter
On Sat, Aug 10, 2013 at 11:19 AM, Chris Wilson wrote: > On Sat, Aug 10, 2013 at 10:55:08AM +0200, Daniel Vetter wrote: >> On Sat, Aug 10, 2013 at 9:06 AM, Guillaume Clement >> wrote: >> > Some Poulsbo cards seem to incorrectly report >> > SDVO_CMD_STATUS_TARGET_NOT_SPECIFIED instead of SDVO_CMD

Re: [PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Chris Wilson
On Sat, Aug 10, 2013 at 10:55:08AM +0200, Daniel Vetter wrote: > On Sat, Aug 10, 2013 at 9:06 AM, Guillaume Clement > wrote: > > Some Poulsbo cards seem to incorrectly report > > SDVO_CMD_STATUS_TARGET_NOT_SPECIFIED instead of SDVO_CMD_STATUS_PENDING, > > which causes the display to be turned o

Re: [PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Daniel Vetter
On Sat, Aug 10, 2013 at 9:06 AM, Guillaume Clement wrote: > Some Poulsbo cards seem to incorrectly report > SDVO_CMD_STATUS_TARGET_NOT_SPECIFIED instead of SDVO_CMD_STATUS_PENDING, > which causes the display to be turned off. > > Signed-off-by: Guillaume Clement Can you please submit the exac

[PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Guillaume Clement
Some Poulsbo cards seem to incorrectly report SDVO_CMD_STATUS_TARGET_NOT_SPECIFIED instead of SDVO_CMD_STATUS_PENDING, which causes the display to be turned off. Signed-off-by: Guillaume Clement --- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)