Re: [PATCH] fs: clean up usage of noop_dirty_folio

2023-08-27 Thread Christoph Hellwig
On Mon, Aug 21, 2023 at 01:20:33PM +0100, Matthew Wilcox wrote: > I was hoping Christoph would weigh in ;-) I don't have a strong I've enjoyed 2 weeks of almost uninterrupted vacation. I agree with this patch and also your incremental improvements.

Re: [PATCH] fs: clean up usage of noop_dirty_folio

2023-08-21 Thread Matthew Wilcox
On Mon, Aug 21, 2023 at 01:16:43PM +0200, Jan Kara wrote: > On Sat 19-08-23 20:42:25, Xueshi Hu wrote: > > In folio_mark_dirty(), it will automatically fallback to > > noop_dirty_folio() if a_ops->dirty_folio is not registered. > > > > As anon_aops, dev_dax_aops and fb_deferred_io_aops becames emp

Re: [PATCH] fs: clean up usage of noop_dirty_folio

2023-08-21 Thread Jan Kara
On Sat 19-08-23 20:42:25, Xueshi Hu wrote: > In folio_mark_dirty(), it will automatically fallback to > noop_dirty_folio() if a_ops->dirty_folio is not registered. > > As anon_aops, dev_dax_aops and fb_deferred_io_aops becames empty, remove > them too. > > Signed-off-by: Xueshi Hu Yeah, looks s

[PATCH] fs: clean up usage of noop_dirty_folio

2023-08-19 Thread Xueshi Hu
In folio_mark_dirty(), it will automatically fallback to noop_dirty_folio() if a_ops->dirty_folio is not registered. As anon_aops, dev_dax_aops and fb_deferred_io_aops becames empty, remove them too. Signed-off-by: Xueshi Hu --- drivers/dax/device.c| 5 - drivers/video/fbdev