Re: [PATCH] fbtft: reduce stack usage

2025-06-10 Thread Andy Shevchenko
On Tue, Jun 10, 2025 at 12:35:14PM +0200, Arnd Bergmann wrote: > On Tue, Jun 10, 2025, at 12:26, Andy Shevchenko wrote: > > On Tue, Jun 10, 2025 at 11:24:38AM +0200, Arnd Bergmann wrote: ... > >> +static noinline_for_stack void fbtft_write_register_64(struct fbtft_par > >> *par, > >> +

Re: [PATCH] fbtft: reduce stack usage

2025-06-10 Thread Arnd Bergmann
On Tue, Jun 10, 2025, at 12:26, Andy Shevchenko wrote: > On Tue, Jun 10, 2025 at 11:24:38AM +0200, Arnd Bergmann wrote: >> Move the varargs handling into a separate noinline function so each >> individual function stays below the limit. A better approach might be to >> replace the varargs function

Re: [PATCH] fbtft: reduce stack usage

2025-06-10 Thread Andy Shevchenko
On Tue, Jun 10, 2025 at 11:24:38AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The use of vararg function pointers combined with a huge number of > arguments causes some configurations to exceed the stack size warning > limit: > > drivers/staging/fbtft/fbtft-core.c:863:12: error: stack

[PATCH] fbtft: reduce stack usage

2025-06-10 Thread Arnd Bergmann
From: Arnd Bergmann The use of vararg function pointers combined with a huge number of arguments causes some configurations to exceed the stack size warning limit: drivers/staging/fbtft/fbtft-core.c:863:12: error: stack frame size (1512) exceeds limit (1280) in 'fbtft_init_display_from_property