Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-11-02 Thread Helge Deller
On 11/1/24 09:19, Thomas Zimmermann wrote: Am 30.10.24 um 10:30 schrieb Helge Deller: I'm happy to get rid of the fbdev drivers, but for that DRM really needs to allow some sort of native fillrect, copyarea and imageblt operations so that we can get performance back on the old cards when impleme

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-11-01 Thread Thomas Zimmermann
Hi Am 30.10.24 um 10:30 schrieb Helge Deller: I'm happy to get rid of the fbdev drivers, but for that DRM really needs to allow some sort of native fillrect, copyarea and imageblt operations so that we can get performance back on the old cards when implementing them as DRM driver. This i

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-30 Thread Helge Deller
On 10/30/24 09:33, Thomas Zimmermann wrote: Hi Am 29.10.24 um 21:42 schrieb Helge Deller: Hi Thomas, On 10/28/24 09:41, Thomas Zimmermann wrote: Am 25.10.24 um 17:37 schrieb Helge Deller: On 10/25/24 11:25, Gonzalo Silvalde Blanco wrote: The fb_udl driver currently depends on CONFIG_FB_DEVI

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-30 Thread Thomas Zimmermann
Hi Am 29.10.24 um 21:42 schrieb Helge Deller: Hi Thomas, On 10/28/24 09:41, Thomas Zimmermann wrote: Am 25.10.24 um 17:37 schrieb Helge Deller: On 10/25/24 11:25, Gonzalo Silvalde Blanco wrote: The fb_udl driver currently depends on CONFIG_FB_DEVICE to create sysfs entries and access framebu

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-29 Thread Helge Deller
Hi Thomas, On 10/28/24 09:41, Thomas Zimmermann wrote: Am 25.10.24 um 17:37 schrieb Helge Deller: On 10/25/24 11:25, Gonzalo Silvalde Blanco wrote: The fb_udl driver currently depends on CONFIG_FB_DEVICE to create sysfs entries and access framebuffer device information. This patch wraps the re

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-28 Thread kernel test robot
rg/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20241025092538.38339-1-gonzalo.silvalde%40gmail.com patch subject: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional config: riscv-randconfig-r073-20241029 (https://download.01.org/0day-ci/archive/20241029/20241029045

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-28 Thread Thomas Zimmermann
Hi Helge Am 25.10.24 um 17:37 schrieb Helge Deller: On 10/25/24 11:25, Gonzalo Silvalde Blanco wrote: The fb_udl driver currently depends on CONFIG_FB_DEVICE to create sysfs entries and access framebuffer device information. This patch wraps the relevant code blocks with #ifdef CONFIG_FB_DEVICE

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-27 Thread kernel test robot
rg/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20241025092538.38339-1-gonzalo.silvalde%40gmail.com patch subject: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional config: i386-randconfig-r121-20241027 (https://download.01.org/0day-ci/archive/20241028/20241028000

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-27 Thread gonzalo . silvalde
Hi Helge, Thank you for your feedback. I understand the concern about the amount of #ifdefs. I’ll review the code to see if there are other ways to handle the conditional dependencies, perhaps by using fb_dbg() or similar, as you suggested. I agree that keeping readability is important, and I

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-25 Thread Helge Deller
On 10/25/24 11:25, Gonzalo Silvalde Blanco wrote: The fb_udl driver currently depends on CONFIG_FB_DEVICE to create sysfs entries and access framebuffer device information. This patch wraps the relevant code blocks with #ifdef CONFIG_FB_DEVICE, allowing the driver to be built and used even if CON

[PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-25 Thread Gonzalo Silvalde Blanco
The fb_udl driver currently depends on CONFIG_FB_DEVICE to create sysfs entries and access framebuffer device information. This patch wraps the relevant code blocks with #ifdef CONFIG_FB_DEVICE, allowing the driver to be built and used even if CONFIG_FB_DEVICE is not selected. The sysfs setting on