Re: [PATCH] fbdev: simplefb: Check before clk_put() not needed

2022-06-20 Thread Helge Deller
On 6/2/22 12:50, Hans de Goede wrote: > Hi, > > On 6/2/22 11:42, Yihao Han wrote: >> clk_put() already checks the clk ptr using !clk and IS_ERR() >> so there is no need to check it again before calling it. >> >> Signed-off-by: Yihao Han >> --- >> drivers/video/fbdev/simplefb.c | 3 +-- >> 1 file

[PATCH] fbdev: simplefb: Check before clk_put() not needed

2022-06-02 Thread Yihao Han
clk_put() already checks the clk ptr using !clk and IS_ERR() so there is no need to check it again before calling it. Signed-off-by: Yihao Han --- drivers/video/fbdev/simplefb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/f

Re: [PATCH] fbdev: simplefb: Check before clk_put() not needed

2022-06-02 Thread Hans de Goede
Hi, On 6/2/22 11:42, Yihao Han wrote: > clk_put() already checks the clk ptr using !clk and IS_ERR() > so there is no need to check it again before calling it. > > Signed-off-by: Yihao Han > --- > drivers/video/fbdev/simplefb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff