Re: [PATCH] fbdev: omapfb: Use sysfs_emit_at() to simplify code

On 8/8/24 14:14, Christophe JAILLET wrote: This file already uses sysfs_emit(). So be consistent and also use sysfs_emit_at(). Moreover, size is always < PAGE_SIZE because scnprintf() (and now sysfs_emit_at()) returns the number of characters written not including the trailing '\0'. So some test

Re: [PATCH] fbdev: omapfb: Use sysfs_emit_at() to simplify code

Hi Christophe, On Thu, Aug 08, 2024 at 02:14:22PM +0200, Christophe JAILLET wrote: > This file already uses sysfs_emit(). So be consistent and also use > sysfs_emit_at(). > > Moreover, size is always < PAGE_SIZE because scnprintf() (and now > sysfs_emit_at()) returns the number of characters writ

[PATCH] fbdev: omapfb: Use sysfs_emit_at() to simplify code

This file already uses sysfs_emit(). So be consistent and also use sysfs_emit_at(). Moreover, size is always < PAGE_SIZE because scnprintf() (and now sysfs_emit_at()) returns the number of characters written not including the trailing '\0'. So some tests can be removed. This slightly simplifies t