Re: [PATCH] fbdev: i810: include i810_main.h in i810_dvt.c

2023-05-19 Thread Helge Deller
On 5/17/23 10:46, Jani Nikula wrote: On Tue, 16 May 2023, Arnd Bergmann wrote: From: Arnd Bergmann Building with W=1 shows that a header needs to be included to make the prototypes visible: drivers/video/fbdev/i810/i810_dvt.c:194:6: error: no previous prototype for 'round_off_xres' [-Werror

Re: [PATCH] fbdev: i810: include i810_main.h in i810_dvt.c

2023-05-17 Thread Jani Nikula
On Wed, 17 May 2023, "Arnd Bergmann" wrote: > On Wed, May 17, 2023, at 10:46, Jani Nikula wrote: >> On Tue, 16 May 2023, Arnd Bergmann wrote: > >>> >>> drivers/video/fbdev/i810/i810_dvt.c:280:5: error: conflicting types for >>> 'i810_get_watermark'; have 'u32(struct fb_var_screeninfo *, >> >> Ch

Re: [PATCH] fbdev: i810: include i810_main.h in i810_dvt.c

2023-05-17 Thread Arnd Bergmann
On Wed, May 17, 2023, at 10:46, Jani Nikula wrote: > On Tue, 16 May 2023, Arnd Bergmann wrote: >> >> drivers/video/fbdev/i810/i810_dvt.c:280:5: error: conflicting types for >> 'i810_get_watermark'; have 'u32(struct fb_var_screeninfo *, > > Changes here look fine, > > Reviewed-by: Jani Nikula T

Re: [PATCH] fbdev: i810: include i810_main.h in i810_dvt.c

2023-05-17 Thread Jani Nikula
On Tue, 16 May 2023, Arnd Bergmann wrote: > From: Arnd Bergmann > > Building with W=1 shows that a header needs to be included to > make the prototypes visible: > > drivers/video/fbdev/i810/i810_dvt.c:194:6: error: no previous prototype for > 'round_off_xres' [-Werror=missing-prototypes] > drive

[PATCH] fbdev: i810: include i810_main.h in i810_dvt.c

2023-05-16 Thread Arnd Bergmann
From: Arnd Bergmann Building with W=1 shows that a header needs to be included to make the prototypes visible: drivers/video/fbdev/i810/i810_dvt.c:194:6: error: no previous prototype for 'round_off_xres' [-Werror=missing-prototypes] drivers/video/fbdev/i810/i810_dvt.c:233:6: error: no previous