Re: [PATCH] fbdev: fix incorrect address computation in deferred IO

2024-04-23 Thread Nam Cao
On Tue, Apr 23, 2024 at 01:27:09PM +0200, Thomas Zimmermann wrote: > Am 23.04.24 um 11:55 schrieb Nam Cao: ... > > > The page-fault handler at [1] use vm_fault.pgoff to retrieve the page > > > structure. Can we do the same here and avoid that computation? > > Yes, thanks for the suggestion. > > >

Re: [PATCH] fbdev: fix incorrect address computation in deferred IO

2024-04-23 Thread Thomas Zimmermann
Hi Am 23.04.24 um 11:55 schrieb Nam Cao: [...] Fix this by taking the mapping offset into account. Reported-and-tested-by: Harshit Mogalapalli Closes: https://lore.kernel.org/linux-fbdev/271372d6-e665-4e7f-b088-dee5f4ab3...@oracle.com Fixes: 56c134f7f1b5 ("fbdev: Track deferred-I/O pages in p

Re: [PATCH] fbdev: fix incorrect address computation in deferred IO

2024-04-23 Thread Nam Cao
On Tue, Apr 23, 2024 at 10:37:41AM +0200, Thomas Zimmermann wrote: > Hi, > > thanks for following through with the bug and sending the patch > > Am 19.04.24 um 21:00 schrieb Nam Cao: > > With deferred IO enabled, a page fault happens when data is written to the > > framebuffer device. Then driver

Re: [PATCH] fbdev: fix incorrect address computation in deferred IO

2024-04-23 Thread Thomas Zimmermann
Hi, thanks for following through with the bug and sending the patch Am 19.04.24 um 21:00 schrieb Nam Cao: With deferred IO enabled, a page fault happens when data is written to the framebuffer device. Then driver determines which page is being updated by calculating the offset of the written vi

[PATCH] fbdev: fix incorrect address computation in deferred IO

2024-04-19 Thread Nam Cao
With deferred IO enabled, a page fault happens when data is written to the framebuffer device. Then driver determines which page is being updated by calculating the offset of the written virtual address within the virtual memory area, and uses this offset to get the updated page within the internal