[PATCH] fbdev: clps711x-fb: unregister fb when clps711x_fb_probe register failed

2024-10-03 Thread clingfei
When register_framebuffer failed, it jumps out_fb_dealloc_cmap without calling unregister_framebuffer, which may cause potential memory leak. Signed-off-by: clingfei --- drivers/video/fbdev/clps711x-fb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/cl

Re: [PATCH] fbdev: clps711x-fb: unregister fb when clps711x_fb_probe register failed

2024-10-03 Thread Russell King (Oracle)
On Fri, Oct 04, 2024 at 12:12:36AM +0800, clingfei wrote: > When register_framebuffer failed, it jumps out_fb_dealloc_cmap without > calling unregister_framebuffer, which may cause potential memory leak. This looks completely wrong. If register_framebuffer() fails, then the work that register_fram