Re: [PATCH] fbdev: atmel_lcdfb: Rework backlight status updates

2022-06-10 Thread Stephen Kitt
On Fri, 10 Jun 2022 10:49:55 +0100, Daniel Thompson wrote: > On Thu, Jun 09, 2022 at 07:45:11PM +0200, Stephen Kitt wrote: > > Hi Sam, Daniel, > > > > On Thu, 9 Jun 2022 19:30:57 +0200, Sam Ravnborg wrote: > > > > > thanks for taking care of all these backlight simplifications - this > > > real

Re: [PATCH] fbdev: atmel_lcdfb: Rework backlight status updates

2022-06-10 Thread Daniel Thompson
On Thu, Jun 09, 2022 at 07:45:11PM +0200, Stephen Kitt wrote: > Hi Sam, Daniel, > > On Thu, 9 Jun 2022 19:30:57 +0200, Sam Ravnborg wrote: > > thanks for taking care of all these backlight simplifications - this > > really helps to make the code simpler and more readable. > > You’re welcome! I not

Re: [PATCH] fbdev: atmel_lcdfb: Rework backlight status updates

2022-06-09 Thread Stephen Kitt
Hi Sam, Daniel, On Thu, 9 Jun 2022 19:30:57 +0200, Sam Ravnborg wrote: > thanks for taking care of all these backlight simplifications - this > really helps to make the code simpler and more readable. You’re welcome! I noticed fb_blank was deprecated and near enough unused, and started digging..

Re: [PATCH] fbdev: atmel_lcdfb: Rework backlight status updates

2022-06-09 Thread Sam Ravnborg
Hi Stephen, thanks for taking care of all these backlight simplifications - this really helps to make the code simpler and more readable. On Thu, Jun 09, 2022 at 10:54:12AM +0100, Daniel Thompson wrote: > On Wed, Jun 08, 2022 at 10:56:23PM +0200, Stephen Kitt wrote: > > Instead of checking the st

Re: [PATCH] fbdev: atmel_lcdfb: Rework backlight status updates

2022-06-09 Thread Daniel Thompson
On Wed, Jun 08, 2022 at 10:56:23PM +0200, Stephen Kitt wrote: > Instead of checking the state of various backlight_properties fields > against the memorised state in atmel_lcdfb_info.bl_power, > atmel_bl_update_status() should retrieve the desired state using > backlight_get_brightness (which takes

[PATCH] fbdev: atmel_lcdfb: Rework backlight status updates

2022-06-08 Thread Stephen Kitt
Instead of checking the state of various backlight_properties fields against the memorised state in atmel_lcdfb_info.bl_power, atmel_bl_update_status() should retrieve the desired state using backlight_get_brightness (which takes into account the power state, blanking etc.). This means the explicit