Re: [PATCH] fbcon: garbage collect fbdev scrolling acceleration

2021-07-12 Thread Geert Uytterhoeven
Hi Hamza, On Fri, Jul 9, 2021 at 11:28 PM Hamza Mahfooz wrote: > On Fri, Jul 9 2021 at 09:49:02 AM +0200, Geert Uytterhoeven > wrote: > > Bummer, more code to revert to re-enable acceleration in the _56_ > > fbdev drivers using acceleration (some of them unusable without), > > despite commit 39a

Re: [PATCH] fbcon: garbage collect fbdev scrolling acceleration

2021-07-09 Thread Hamza Mahfooz
On Fri, Jul 9 2021 at 09:49:02 AM +0200, Geert Uytterhoeven wrote: Bummer, more code to revert to re-enable acceleration in the _56_ fbdev drivers using acceleration (some of them unusable without), despite commit 39aead8373b3 claiming "No other driver supportes accelerated fbcon"... Should t

Re: [PATCH] fbcon: garbage collect fbdev scrolling acceleration

2021-07-09 Thread Daniel Vetter
On Thu, Jul 08, 2021 at 09:00:38PM -0400, Hamza Mahfooz wrote: > As per commit 39aead8373b3 ("fbcon: Disable accelerated scrolling"), we can That commit is only in 5.11, so not yet even in an LTS. We should wait at least that long. Also there's some objections from Geert. -Daniel > now remove all

Re: [PATCH] fbcon: garbage collect fbdev scrolling acceleration

2021-07-09 Thread Geert Uytterhoeven
On Fri, Jul 9, 2021 at 3:04 AM Hamza Mahfooz wrote: > As per commit 39aead8373b3 ("fbcon: Disable accelerated scrolling"), we can > now remove all of the code that was made redundant by disabling scrolling > acceleration. Bummer, more code to revert to re-enable acceleration in the _56_ fbdev dri

[PATCH] fbcon: garbage collect fbdev scrolling acceleration

2021-07-08 Thread Hamza Mahfooz
As per commit 39aead8373b3 ("fbcon: Disable accelerated scrolling"), we can now remove all of the code that was made redundant by disabling scrolling acceleration. Signed-off-by: Hamza Mahfooz --- drivers/video/fbdev/core/bitblit.c | 16 - drivers/video/fbdev/core/fbcon.c| 520 +---