Re: [PATCH] fbcon: Remove the superfluous break

2020-09-18 Thread Daniel Vetter
On Fri, Sep 18, 2020 at 08:52:02AM +0800, Jing Xiangfeng wrote: > > > On 2020/9/18 2:52, Gustavo A. R. Silva wrote: > > > > > > On 9/17/20 08:15, Jing Xiangfeng wrote: > > > Remove the superfuous break, as there is a 'return' before it. > > > > > > Signed-off-by: Jing Xiangfeng > > > > Revie

Re: [PATCH] fbcon: Remove the superfluous break

2020-09-18 Thread Jing Xiangfeng
On 2020/9/18 2:52, Gustavo A. R. Silva wrote: On 9/17/20 08:15, Jing Xiangfeng wrote: Remove the superfuous break, as there is a 'return' before it. Signed-off-by: Jing Xiangfeng Reviewed-by: Gustavo A. R. Silva Also, the following Fixes tag should be included in the changelog text:

Re: [PATCH] fbcon: Remove the superfluous break

2020-09-18 Thread Jing Xiangfeng
On 2020/9/18 1:36, Nick Desaulniers wrote: On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng wrote: Remove the superfuous break, as there is a 'return' before it. superfluous (missed "l") Thanks for correcting! Signed-off-by: Jing Xiangfeng Reviewed-by: Nick Desaulniers Thanks for

Re: [PATCH] fbcon: Remove the superfluous break

2020-09-17 Thread Gustavo A. R. Silva
On 9/17/20 08:15, Jing Xiangfeng wrote: > Remove the superfuous break, as there is a 'return' before it. > > Signed-off-by: Jing Xiangfeng Reviewed-by: Gustavo A. R. Silva Also, the following Fixes tag should be included in the changelog text: Fixes: bad07ff74c32 ("fbcon: smart blitter usa

[PATCH] fbcon: Remove the superfluous break

2020-09-17 Thread Jing Xiangfeng
Remove the superfuous break, as there is a 'return' before it. Signed-off-by: Jing Xiangfeng --- drivers/video/fbdev/core/fbcon.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 0b49b0f44edf..623359aadd1e 100644 --- a