Re: [PATCH] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-09-20 Thread Qianqiang Liu
Hi, I simplified the C reproducer as follows: #include #include #include #include #include #include #include #include struct param { uint8_t type; struct tiocl_selection ts; }; int main() { write(1, "executing program\n", sizeof("executing program\n") - 1);

[PATCH] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-09-17 Thread Qianqiang Liu
 > I think this patch just hides the real problem. > How could putcs have become NULL ? > > Helge Oh, you are right! I will figure it out. Best, Qianqiang Liu

Re: [PATCH] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-09-16 Thread Helge Deller
On 9/16/24 03:10, Qianqiang Liu wrote: syzbot has found a NULL pointer dereference bug in fbcon [1]. This issue is caused by ops->putcs being a NULL pointer. We need to check the pointer before using it. [1] https://syzkaller.appspot.com/bug?extid=3d613ae53c031502687a Cc: sta...@vger.kernel.or

[PATCH] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-09-15 Thread Qianqiang Liu
syzbot has found a NULL pointer dereference bug in fbcon [1]. This issue is caused by ops->putcs being a NULL pointer. We need to check the pointer before using it. [1] https://syzkaller.appspot.com/bug?extid=3d613ae53c031502687a Cc: sta...@vger.kernel.org Reported-and-tested-by: syzbot+3d613ae5