Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-28 Thread Ard Biesheuvel
On Wed, 28 Jul 2021 at 10:39, Geert Uytterhoeven wrote: > > Hi Randy, > > On Tue, Jul 27, 2021 at 7:06 AM Randy Dunlap wrote: > > When # CONFIG_EFI is not set, there are 2 definitions of > > sysfb_apply_efi_quirks(). The stub from sysfb.h should be used > > and the __init function from sysfb_efi.

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-28 Thread Geert Uytterhoeven
Hi Randy, On Tue, Jul 27, 2021 at 7:06 AM Randy Dunlap wrote: > When # CONFIG_EFI is not set, there are 2 definitions of > sysfb_apply_efi_quirks(). The stub from sysfb.h should be used > and the __init function from sysfb_efi.c should not be used. > > ../drivers/firmware/efi/sysfb_efi.c:337:13:

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-27 Thread kernel test robot
Hi Randy, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20210726] [cannot apply to efi/next linux/master linus/master v5.14-rc3 v5.14-rc2 v5.14-rc1 v5.14-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting pat

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-27 Thread Daniel Vetter
On Tue, Jul 27, 2021 at 11:15:36AM +0200, Thomas Zimmermann wrote: > Hi > > Am 27.07.21 um 07:04 schrieb Randy Dunlap: > > When # CONFIG_EFI is not set, there are 2 definitions of > > sysfb_apply_efi_quirks(). The stub from sysfb.h should be used > > and the __init function from sysfb_efi.c should

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-27 Thread Thomas Zimmermann
Hi Am 27.07.21 um 07:04 schrieb Randy Dunlap: When # CONFIG_EFI is not set, there are 2 definitions of sysfb_apply_efi_quirks(). The stub from sysfb.h should be used and the __init function from sysfb_efi.c should not be used. ../drivers/firmware/efi/sysfb_efi.c:337:13: error: redefinition of

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-27 Thread Javier Martinez Canillas
On 7/27/21 7:04 AM, Randy Dunlap wrote: > When # CONFIG_EFI is not set, there are 2 definitions of > sysfb_apply_efi_quirks(). The stub from sysfb.h should be used > and the __init function from sysfb_efi.c should not be used. > > ../drivers/firmware/efi/sysfb_efi.c:337:13: error: redefinition of

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-27 Thread Ard Biesheuvel
On Tue, 27 Jul 2021 at 07:05, Randy Dunlap wrote: > > When # CONFIG_EFI is not set, there are 2 definitions of > sysfb_apply_efi_quirks(). The stub from sysfb.h should be used > and the __init function from sysfb_efi.c should not be used. > > ../drivers/firmware/efi/sysfb_efi.c:337:13: error: rede

[PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-26 Thread Randy Dunlap
When # CONFIG_EFI is not set, there are 2 definitions of sysfb_apply_efi_quirks(). The stub from sysfb.h should be used and the __init function from sysfb_efi.c should not be used. ../drivers/firmware/efi/sysfb_efi.c:337:13: error: redefinition of ‘sysfb_apply_efi_quirks’ __init void sysfb_apply