Re: [PATCH] drm-buf: Add debug option

2021-02-16 Thread John Stultz
On Tue, Feb 16, 2021 at 7:30 PM John Stultz wrote: > > On Wed, Jan 13, 2021 at 6:06 AM Daniel Vetter wrote: > > > > We have too many people abusing the struct page they can get at but > > really shouldn't in importers. Aside from that the backing page might > > simply not exist (for dynamic p2p m

Re: [PATCH] drm-buf: Add debug option

2021-02-16 Thread John Stultz
On Wed, Jan 13, 2021 at 6:06 AM Daniel Vetter wrote: > > We have too many people abusing the struct page they can get at but > really shouldn't in importers. Aside from that the backing page might > simply not exist (for dynamic p2p mappings) looking at it and using it > e.g. for mmap can also wre

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-15 Thread John Stultz
On Thu, Jan 14, 2021 at 1:03 AM Daniel Vetter wrote: > > On Wed, Jan 13, 2021 at 10:08 PM Chris Wilson > wrote: > > Quoting Daniel Vetter (2021-01-13 20:50:11) > > > On Wed, Jan 13, 2021 at 4:43 PM Chris Wilson > > > wrote: > > > > > > > > Quoting Daniel Vetter (2021-01-13 14:06:04) > > > > >

Re: [PATCH] drm-buf: Add debug option

2021-01-15 Thread kernel test robot
Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20210115] [also build test WARNING on v5.11-rc3] [cannot apply to tegra-drm/drm/tegra/for-next linus/master v5.11-rc3 v5.11-rc2 v5.11-rc1] [If your patch is applied to the wrong git tree, kindly drop us

Re: [Linaro-mm-sig] [PATCH] drm-buf: Add debug option

2021-01-15 Thread Christian König
Am 15.01.21 um 14:22 schrieb Daniel Vetter: On Fri, Jan 15, 2021 at 2:09 PM Christian König wrote: Am 15.01.21 um 14:02 schrieb Daniel Vetter: have too many people abusing the struct page they can get at but really shouldn't in importers. Aside from that the backing page might simply not exist

Re: [Linaro-mm-sig] [PATCH] drm-buf: Add debug option

2021-01-15 Thread Daniel Vetter
On Fri, Jan 15, 2021 at 2:09 PM Christian König wrote: > > Am 15.01.21 um 14:02 schrieb Daniel Vetter: > > have too many people abusing the struct page they can get at but > > really shouldn't in importers. Aside from that the backing page might > > simply not exist (for dynamic p2p mappings) look

Re: [Linaro-mm-sig] [PATCH] drm-buf: Add debug option

2021-01-15 Thread Christian König
Am 15.01.21 um 14:02 schrieb Daniel Vetter: We have too many people abusing the struct page they can get at but really shouldn't in importers. Aside from that the backing page might simply not exist (for dynamic p2p mappings) looking at it and using it e.g. for mmap can also wreak the page handli

[PATCH] drm-buf: Add debug option

2021-01-15 Thread Daniel Vetter
We have too many people abusing the struct page they can get at but really shouldn't in importers. Aside from that the backing page might simply not exist (for dynamic p2p mappings) looking at it and using it e.g. for mmap can also wreak the page handling of the exporter completely. Importers reall

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-15 Thread Chris Wilson
Quoting Daniel Vetter (2021-01-14 09:47:40) > On Thu, Jan 14, 2021 at 09:45:37AM +, Chris Wilson wrote: > > Quoting Daniel Vetter (2021-01-14 09:30:32) > > > On Thu, Jan 14, 2021 at 10:23 AM Chris Wilson > > > wrote: > > > > The only other problem I see with the implementation is that there's

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 09:45:37AM +, Chris Wilson wrote: > Quoting Daniel Vetter (2021-01-14 09:30:32) > > On Thu, Jan 14, 2021 at 10:23 AM Chris Wilson > > wrote: > > > The only other problem I see with the implementation is that there's > > > nothing that says that each dmabuf->ops->map_dm

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-14 Thread Chris Wilson
Quoting Daniel Vetter (2021-01-14 09:30:32) > On Thu, Jan 14, 2021 at 10:23 AM Chris Wilson > wrote: > > The only other problem I see with the implementation is that there's > > nothing that says that each dmabuf->ops->map_dma_buf() returns a new > > sg_table, so we may end up undoing the xor. Or

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 10:23 AM Chris Wilson wrote: > > Quoting Daniel Vetter (2021-01-14 09:02:57) > > On Wed, Jan 13, 2021 at 10:08 PM Chris Wilson > > wrote: > > > Quoting Daniel Vetter (2021-01-13 20:50:11) > > > > On Wed, Jan 13, 2021 at 4:43 PM Chris Wilson > > > > wrote: > > > > > > >

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-14 Thread Chris Wilson
Quoting Daniel Vetter (2021-01-14 09:02:57) > On Wed, Jan 13, 2021 at 10:08 PM Chris Wilson > wrote: > > Quoting Daniel Vetter (2021-01-13 20:50:11) > > > On Wed, Jan 13, 2021 at 4:43 PM Chris Wilson > > > wrote: > > > > > > > > Quoting Daniel Vetter (2021-01-13 14:06:04) > > > > > We have too

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-14 Thread Daniel Vetter
On Wed, Jan 13, 2021 at 10:08 PM Chris Wilson wrote: > Quoting Daniel Vetter (2021-01-13 20:50:11) > > On Wed, Jan 13, 2021 at 4:43 PM Chris Wilson > > wrote: > > > > > > Quoting Daniel Vetter (2021-01-13 14:06:04) > > > > We have too many people abusing the struct page they can get at but > > >

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-13 Thread Chris Wilson
Quoting Daniel Vetter (2021-01-13 20:50:11) > On Wed, Jan 13, 2021 at 4:43 PM Chris Wilson wrote: > > > > Quoting Daniel Vetter (2021-01-13 14:06:04) > > > We have too many people abusing the struct page they can get at but > > > really shouldn't in importers. Aside from that the backing page migh

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-13 Thread Daniel Vetter
On Wed, Jan 13, 2021 at 4:43 PM Chris Wilson wrote: > > Quoting Daniel Vetter (2021-01-13 14:06:04) > > We have too many people abusing the struct page they can get at but > > really shouldn't in importers. Aside from that the backing page might > > simply not exist (for dynamic p2p mappings) look

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-13 Thread Chris Wilson
Quoting Daniel Vetter (2021-01-13 14:06:04) > We have too many people abusing the struct page they can get at but > really shouldn't in importers. Aside from that the backing page might > simply not exist (for dynamic p2p mappings) looking at it and using it > e.g. for mmap can also wreak the page

[PATCH] drm-buf: Add debug option

2021-01-13 Thread Daniel Vetter
We have too many people abusing the struct page they can get at but really shouldn't in importers. Aside from that the backing page might simply not exist (for dynamic p2p mappings) looking at it and using it e.g. for mmap can also wreak the page handling of the exporter completely. Importers reall