Re: Re:Re: [PATCH] drm:bridge:analogix: Fix refcount bugs in anx7625_parse_dt()

2022-07-18 Thread Robert Foss
On Mon, 18 Jul 2022 at 15:35, Liang He wrote: > > > At 2022-07-18 19:56:09, "Liang He" wrote: > > > >At 2022-07-18 19:54:18, "Robert Foss" wrote: > >>Hey Liang, > >> > >> > >>On Thu, 7 Jul 2022 at 03:25, Liang He wrote: > >>> > >>> There are two refcount bugs in this funcion: > >>> > >>> BUG-1:

Re:Re:Re: [PATCH] drm:bridge:analogix: Fix refcount bugs in anx7625_parse_dt()

2022-07-18 Thread Liang He
At 2022-07-18 19:56:09, "Liang He" wrote: > >At 2022-07-18 19:54:18, "Robert Foss" wrote: >>Hey Liang, >> >> >>On Thu, 7 Jul 2022 at 03:25, Liang He wrote: >>> >>> There are two refcount bugs in this funcion: >>> >>> BUG-1: 'pdata->mipi_host_node' will be assigned a new reference with >>> of_gr

Re:Re: [PATCH] drm:bridge:analogix: Fix refcount bugs in anx7625_parse_dt()

2022-07-18 Thread Liang He
At 2022-07-18 19:55:16, "Robert Foss" wrote: >On Mon, 18 Jul 2022 at 13:54, Robert Foss wrote: >> >> Hey Liang, >> >> >> On Thu, 7 Jul 2022 at 03:25, Liang He wrote: >> > >> > There are two refcount bugs in this funcion: >> > >> > BUG-1: 'pdata->mipi_host_node' will be assigned a new reference

Re:Re: [PATCH] drm:bridge:analogix: Fix refcount bugs in anx7625_parse_dt()

2022-07-18 Thread Liang He
At 2022-07-18 19:54:18, "Robert Foss" wrote: >Hey Liang, > > >On Thu, 7 Jul 2022 at 03:25, Liang He wrote: >> >> There are two refcount bugs in this funcion: >> >> BUG-1: 'pdata->mipi_host_node' will be assigned a new reference with >> of_graph_get_remote_node() which will increase the refcount

Re: [PATCH] drm:bridge:analogix: Fix refcount bugs in anx7625_parse_dt()

2022-07-18 Thread Robert Foss
On Mon, 18 Jul 2022 at 13:54, Robert Foss wrote: > > Hey Liang, > > > On Thu, 7 Jul 2022 at 03:25, Liang He wrote: > > > > There are two refcount bugs in this funcion: > > > > BUG-1: 'pdata->mipi_host_node' will be assigned a new reference with > > of_graph_get_remote_node() which will increase t

Re: [PATCH] drm:bridge:analogix: Fix refcount bugs in anx7625_parse_dt()

2022-07-18 Thread Robert Foss
Hey Liang, On Thu, 7 Jul 2022 at 03:25, Liang He wrote: > > There are two refcount bugs in this funcion: > > BUG-1: 'pdata->mipi_host_node' will be assigned a new reference with > of_graph_get_remote_node() which will increase the refcount of the > object, correspondingly, we should call of_node

[PATCH] drm:bridge:analogix: Fix refcount bugs in anx7625_parse_dt()

2022-07-06 Thread Liang He
There are two refcount bugs in this funcion: BUG-1: 'pdata->mipi_host_node' will be assigned a new reference with of_graph_get_remote_node() which will increase the refcount of the object, correspondingly, we should call of_node_put() for the old reference stored in the 'pdata->mipi_host_node'. B