Re: [PATCH] drm: use drm_dev_has_vblank more

2020-05-29 Thread Daniel Vetter
On Wed, May 27, 2020 at 02:02:12PM +0200, Thomas Zimmermann wrote: > > Am 27.05.20 um 13:11 schrieb Daniel Vetter: > > For historical reasons it's called dev->num_crtcs, which is rather > > confusing ever since kms was added. But now we have a nice helper, so > > let's use it for better readabilit

Re: [PATCH] drm: use drm_dev_has_vblank more

2020-05-27 Thread Sam Ravnborg
On Wed, May 27, 2020 at 01:11:34PM +0200, Daniel Vetter wrote: > For historical reasons it's called dev->num_crtcs, which is rather > confusing ever since kms was added. But now we have a nice helper, so > let's use it for better readability! > > Only code change is in atomic helpers: vblank suppo

Re: [PATCH] drm: use drm_dev_has_vblank more

2020-05-27 Thread Thomas Zimmermann
Am 27.05.20 um 13:11 schrieb Daniel Vetter: > For historical reasons it's called dev->num_crtcs, which is rather > confusing ever since kms was added. But now we have a nice helper, so > let's use it for better readability! > > Only code change is in atomic helpers: vblank support means that > de

[PATCH] drm: use drm_dev_has_vblank more

2020-05-27 Thread Daniel Vetter
For historical reasons it's called dev->num_crtcs, which is rather confusing ever since kms was added. But now we have a nice helper, so let's use it for better readability! Only code change is in atomic helpers: vblank support means that dev->irq_enabled must be set too. Another one of these quir