Re: [PATCH] drm: use atomic helper function to get crtc_state of crtc

2018-06-19 Thread Ville Syrjälä
On Tue, Jun 19, 2018 at 05:27:57PM +0200, Daniel Vetter wrote: > On Tue, Jun 19, 2018 at 10:45:31AM -0400, mikita.lip...@amd.com wrote: > > From: Mikita Lipski > > > > Use drm_atomic_get_crtc_state to get the crtc state in case > > it has been previously freed, that might prevent use-after-free i

Re: [PATCH] drm: use atomic helper function to get crtc_state of crtc

2018-06-19 Thread Daniel Vetter
On Tue, Jun 19, 2018 at 10:45:31AM -0400, mikita.lip...@amd.com wrote: > From: Mikita Lipski > > Use drm_atomic_get_crtc_state to get the crtc state in case > it has been previously freed, that might prevent use-after-free issue. > > This patch fixes the bugzilla bug: > Bug 199425 - BUG: KASAN:

Re: [PATCH] drm: use atomic helper function to get crtc_state of crtc

2018-06-19 Thread Michel Dänzer
Hi Mikita, thanks for sending this out. I have to defer review of the actual change to others more familiar with this code, but I have some feedback for the commit log. On 2018-06-19 04:45 PM, mikita.lip...@amd.com wrote: > From: Mikita Lipski > > Use drm_atomic_get_crtc_state to get the crt

[PATCH] drm: use atomic helper function to get crtc_state of crtc

2018-06-19 Thread mikita.lipski
From: Mikita Lipski Use drm_atomic_get_crtc_state to get the crtc state in case it has been previously freed, that might prevent use-after-free issue. This patch fixes the bugzilla bug: Bug 199425 - BUG: KASAN: use-after-free in drm_atomic_helper_wait_for_flip_done+0x247/0x260 Signed-off-by: M