Re: [PATCH] drm: tweak drm_print_bits()

2019-09-20 Thread Thierry Reding
On Thu, Sep 19, 2019 at 03:14:11PM +0200, Gerd Hoffmann wrote: > There is little reason for the from/to logic, printing a subset of > the bits can be done by simply shifting/masking value if needed. > > Also use for_each_set_bit(). > > Suggested-by: Jani Nikula > Signed-off-by: Gerd Hoffmann >

Re: [PATCH] drm: tweak drm_print_bits()

2019-09-19 Thread Jani Nikula
On Thu, 19 Sep 2019, Gerd Hoffmann wrote: > There is little reason for the from/to logic, printing a subset of > the bits can be done by simply shifting/masking value if needed. > > Also use for_each_set_bit(). Oh, I don't know why I stumbled upon and reviewed a patch that had already been merged

[PATCH] drm: tweak drm_print_bits()

2019-09-19 Thread Gerd Hoffmann
There is little reason for the from/to logic, printing a subset of the bits can be done by simply shifting/masking value if needed. Also use for_each_set_bit(). Suggested-by: Jani Nikula Signed-off-by: Gerd Hoffmann --- include/drm/drm_print.h | 5 ++--- drivers/gpu/drm/drm_gem_t