Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-10-03 Thread Maxime Ripard
On Tue, Sep 24, 2019 at 02:40:54PM +0200, Ondřej Jirman wrote: > > > On first run of the X server, only the black screen and the layer > > > containing the cursor is visible. Switching to console and back > > > corrects the situation. > > > > > > I have dumped registers, and found out this: > >

Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-09-30 Thread Ondřej Jirman
Hi, On Tue, Sep 24, 2019 at 02:40:54PM +0200, megous hlavni wrote: > > > On first run of the X server, only the black screen and the layer > > > containing the cursor is visible. Switching to console and back > > > corrects the situation. > > > > > > I have dumped registers, and found out this

Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-09-24 Thread Ondřej Jirman
On Fri, Sep 20, 2019 at 05:11:42PM +0200, Maxime Ripard wrote: > On Thu, Sep 19, 2019 at 03:12:44PM +0200, Ondřej Jirman wrote: > > On Thu, Sep 19, 2019 at 02:20:58PM +0200, megous hlavni wrote: > > > On Wed, Sep 18, 2019 at 10:16:17PM +0200, Maxime Ripard wrote: > > > > On Wed, Sep 18, 2019 at 05:

Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-09-20 Thread Maxime Ripard
On Thu, Sep 19, 2019 at 03:12:44PM +0200, Ondřej Jirman wrote: > On Thu, Sep 19, 2019 at 02:20:58PM +0200, megous hlavni wrote: > > On Wed, Sep 18, 2019 at 10:16:17PM +0200, Maxime Ripard wrote: > > > On Wed, Sep 18, 2019 at 05:23:09PM +0200, Ondřej Jirman wrote: > > > > Hi, > > > > > > > > On Wed,

Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-09-19 Thread Ondřej Jirman
On Thu, Sep 19, 2019 at 02:20:58PM +0200, megous hlavni wrote: > On Wed, Sep 18, 2019 at 10:16:17PM +0200, Maxime Ripard wrote: > > On Wed, Sep 18, 2019 at 05:23:09PM +0200, Ondřej Jirman wrote: > > > Hi, > > > > > > On Wed, Sep 18, 2019 at 04:17:34PM +0200, Maxime Ripard wrote: > > > > Hi, > > > >

Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-09-19 Thread Ondřej Jirman
On Wed, Sep 18, 2019 at 10:16:17PM +0200, Maxime Ripard wrote: > On Wed, Sep 18, 2019 at 05:23:09PM +0200, Ondřej Jirman wrote: > > Hi, > > > > On Wed, Sep 18, 2019 at 04:17:34PM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > On Sun, Sep 15, 2019 at 12:03:37AM +0200, meg...@megous.com wrote: > >

Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-09-18 Thread Maxime Ripard
On Wed, Sep 18, 2019 at 05:23:09PM +0200, Ondřej Jirman wrote: > Hi, > > On Wed, Sep 18, 2019 at 04:17:34PM +0200, Maxime Ripard wrote: > > Hi, > > > > On Sun, Sep 15, 2019 at 12:03:37AM +0200, meg...@megous.com wrote: > > > From: Ondrej Jirman > > > > > > There are various issues that this re-wor

Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-09-18 Thread Ondřej Jirman
Hi, On Wed, Sep 18, 2019 at 04:17:34PM +0200, Maxime Ripard wrote: > Hi, > > On Sun, Sep 15, 2019 at 12:03:37AM +0200, meg...@megous.com wrote: > > From: Ondrej Jirman > > > > There are various issues that this re-work of sun8i_[uv]i_layer_enable > > function fixes: > > > > - Make sure that we r

Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-09-18 Thread Maxime Ripard
Hi, On Sun, Sep 15, 2019 at 12:03:37AM +0200, meg...@megous.com wrote: > From: Ondrej Jirman > > There are various issues that this re-work of sun8i_[uv]i_layer_enable > function fixes: > > - Make sure that we re-initialize zpos on reset > - Minimize register updates by doing them only when state

Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-09-14 Thread Ondřej Jirman
On Sun, Sep 15, 2019 at 12:03:37AM +0200, megous hlavni wrote: > From: Ondrej Jirman > > There are various issues that this re-work of sun8i_[uv]i_layer_enable > function fixes: > > - Make sure that we re-initialize zpos on reset > - Minimize register updates by doing them only when state change

[PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-09-14 Thread megous
From: Ondrej Jirman There are various issues that this re-work of sun8i_[uv]i_layer_enable function fixes: - Make sure that we re-initialize zpos on reset - Minimize register updates by doing them only when state changes - Fix issue where DE pipe might get disabled even if it is no longer used