[PATCH] drm: serialize access to debugs_nodes.list

2011-10-31 Thread Marcin Slusarz
On Mon, Oct 31, 2011 at 09:06:57AM +0100, Daniel Vetter wrote: > This is just ugly, you're adding a mutex to every drm_info_node, but only > use the one embedded into the minor. On a quick grep we're only ever using > the list in there, so I suggest to > - replace minor->debugfs_node.list with mino

Re: [PATCH] drm: serialize access to debugs_nodes.list

2011-10-31 Thread Marcin Slusarz
On Mon, Oct 31, 2011 at 09:06:57AM +0100, Daniel Vetter wrote: > This is just ugly, you're adding a mutex to every drm_info_node, but only > use the one embedded into the minor. On a quick grep we're only ever using > the list in there, so I suggest to > - replace minor->debugfs_node.list with mino

[PATCH] drm: serialize access to debugs_nodes.list

2011-10-31 Thread Daniel Vetter
On Sun, Oct 30, 2011 at 11:04:48PM +0100, Marcin Slusarz wrote: > Nouveau, when configured with debugfs, creates debugfs files for every > channel, so structure holding list of files needs to be protected from > simultaneous changes by multiple threads. > > Without this patch it's possible to hit

Re: [PATCH] drm: serialize access to debugs_nodes.list

2011-10-31 Thread Daniel Vetter
On Sun, Oct 30, 2011 at 11:04:48PM +0100, Marcin Slusarz wrote: > Nouveau, when configured with debugfs, creates debugfs files for every > channel, so structure holding list of files needs to be protected from > simultaneous changes by multiple threads. > > Without this patch it's possible to hit

[PATCH] drm: serialize access to debugs_nodes.list

2011-10-30 Thread Marcin Slusarz
Nouveau, when configured with debugfs, creates debugfs files for every channel, so structure holding list of files needs to be protected from simultaneous changes by multiple threads. Without this patch it's possible to hit kernel oops in drm_debugfs_remove_files just by running a couple of xterms

[PATCH] drm: serialize access to debugs_nodes.list

2011-10-30 Thread Marcin Slusarz
Nouveau, when configured with debugfs, creates debugfs files for every channel, so structure holding list of files needs to be protected from simultaneous changes by multiple threads. Without this patch it's possible to hit kernel oops in drm_debugfs_remove_files just by running a couple of xterms