Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread kernel test robot
Hi Jackie, Thank you for the patch! Yet something to improve: [auto build test ERROR on pinchartl-media/drm/du/next] [also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.14-rc3 next-20210727] [cannot apply to drm/drm-next]

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Jackie Liu
Hi Kieran. Thanks for replying to the email so quickly. 在 2021/7/28 下午4:58, Kieran Bingham 写道: Hi Jackie, On 28/07/2021 09:42, Jackie Liu wrote: From: Jackie Liu After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM operations"), the cmm module must be included in the crtc. We cann

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Jackie Liu
Hi Kieran. 在 2021/7/28 下午8:13, Kieran Bingham 写道: Hi Jackie / Laurent, On 28/07/2021 12:30, Laurent Pinchart wrote: On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote: Hi Jackie, On 28/07/2021 10:57, Jackie Liu wrote: Hi Kieran. How about this. diff --git a/drivers/gpu/drm/rca

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Jackie Liu
Hi Kieran. How about this. diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index b47e74421e34..14cf3e6415d7 100644 --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 config DRM_RCAR_DU

[PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Jackie Liu
From: Jackie Liu After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM operations"), the cmm module must be included in the crtc. We cannot remove this configuration option separately. Therefore, simply linking them together is the best solution, otherwise some errors will be reported.

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Jackie Liu
Hi Kieran. 在 2021/7/28 下午8:24, Kieran Bingham 写道: > Hi Jackie > > On 28/07/2021 13:21, Jackie Liu wrote: >> Hi Kieran. >> >> 在 2021/7/28 下午8:13, Kieran Bingham 写道: >>> Hi Jackie / Laurent, >>> >>> On 28/07/2021 12:30, Laurent Pinchart wrote: On Wed, Jul 28, 2021 at 12:09

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Jackie Liu
在 2021/7/28 下午7:30, Laurent Pinchart 写道: On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote: Hi Jackie, On 28/07/2021 10:57, Jackie Liu wrote: Hi Kieran. How about this. diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index b47e74421e34..14cf3e64

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Kieran Bingham
Hi Jackie On 28/07/2021 13:21, Jackie Liu wrote: > Hi Kieran. > > 在 2021/7/28 下午8:13, Kieran Bingham 写道: >> Hi Jackie / Laurent, >> >> On 28/07/2021 12:30, Laurent Pinchart wrote: >>> On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote: Hi Jackie, On 28/07/2021 10:57, Ja

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Kieran Bingham
Hi Jackie / Laurent, On 28/07/2021 12:30, Laurent Pinchart wrote: > On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote: >> Hi Jackie, >> >> On 28/07/2021 10:57, Jackie Liu wrote: >>> Hi Kieran. >>> >>> How about this. >>> >>> diff --git a/drivers/gpu/drm/rcar-du/Kconfig >>> b/drivers/g

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Laurent Pinchart
On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote: > Hi Jackie, > > On 28/07/2021 10:57, Jackie Liu wrote: > > Hi Kieran. > > > > How about this. > > > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig > > b/drivers/gpu/drm/rcar-du/Kconfig > > index b47e74421e34..14cf3e6415d7 100644 >

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Kieran Bingham
Hi Jackie, On 28/07/2021 10:57, Jackie Liu wrote: > Hi Kieran. > > How about this. > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig > b/drivers/gpu/drm/rcar-du/Kconfig > index b47e74421e34..14cf3e6415d7 100644 > --- a/drivers/gpu/drm/rcar-du/Kconfig > +++ b/drivers/gpu/drm/rcar-du/Kconfig > @@ -

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Laurent Pinchart
Hi Jackie, On Wed, Jul 28, 2021 at 05:34:38PM +0800, Jackie Liu wrote: > 在 2021/7/28 下午4:58, Kieran Bingham 写道: > > On 28/07/2021 09:42, Jackie Liu wrote: > >> From: Jackie Liu > >> > >> After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM > >> operations"), > >> the cmm module must be

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Kieran Bingham
On 28/07/2021 10:34, Jackie Liu wrote: > Hi Kieran. > > Thanks for replying to the email so quickly. > > 在 2021/7/28 下午4:58, Kieran Bingham 写道: >> Hi Jackie, >> >> On 28/07/2021 09:42, Jackie Liu wrote: >>> From: Jackie Liu >>> >>> After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM >

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Kieran Bingham
Hi Jackie, On 28/07/2021 09:42, Jackie Liu wrote: > From: Jackie Liu > > After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM operations"), > the cmm module must be included in the crtc. We cannot remove this > configuration option separately. Therefore, simply linking them together >