Re: [PATCH] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-16 Thread Laurent Pinchart
Hi Jacopo, On Wed, Dec 16, 2020 at 02:51:34PM +0100, Jacopo Mondi wrote: > Hi Laurent, > > I wonder if 'leaked' is correct in subject. It probably is, > un-balanced ref-counting will prevent the device from being released. > It should however happen only at system tear-down, doesn't it ? As the

Re: [PATCH] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-16 Thread Jacopo Mondi
Hi Laurent, I wonder if 'leaked' is correct in subject. It probably is, un-balanced ref-counting will prevent the device from being released. It should however happen only at system tear-down, doesn't it ? On Wed, Dec 16, 2020 at 03:22:18AM +0200, Laurent Pinchart wrote: > The device references a

[PATCH] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-15 Thread Laurent Pinchart
The device references acquired by of_find_device_by_node() are not released by the driver. Fix this by registering a cleanup action. Fixes: 8de707aeb452 ("drm: rcar-du: kms: Initialize CMM instances") Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 20