Re: [PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug

2023-02-27 Thread Laurent Pinchart
Hi Dan, Thank you for the patch. On Mon, Feb 27, 2023 at 01:06:59PM +0300, Dan Carpenter wrote: > The drmm_encoder_alloc() function returns error pointers. It never > returns NULL. Fix the check accordingly. > > Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage > encoder"

Re: [PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug

2023-02-27 Thread Kieran Bingham
Quoting Dan Carpenter (2023-02-27 10:06:59) > The drmm_encoder_alloc() function returns error pointers. It never > returns NULL. Fix the check accordingly. Yes, indeed. Thanks. Reviewed-by: Kieran Bingham > > Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage > encoder")

[PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug

2023-02-27 Thread Dan Carpenter
The drmm_encoder_alloc() function returns error pointers. It never returns NULL. Fix the check accordingly. Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 ++-- 1 file changed, 2 in