Re: [PATCH] drm: omapdrm: reduce clang stack usage

2025-06-12 Thread Arnd Bergmann
On Thu, Jun 12, 2025, at 16:37, Tomi Valkeinen wrote: > On 12/06/2025 15:40, Arnd Bergmann wrote: > static u16 DISPC_OVL_BASE(enum omap_plane_id plane) > { > static const u16 bases[] = {0x0080, 0x00BC, 0x014C, 0x0300, 0x0500}; > return bases[plane]; > } > > In any case, I'll apply this wit

Re: [PATCH] drm: omapdrm: reduce clang stack usage

2025-06-12 Thread Tomi Valkeinen
Hi, On 12/06/2025 15:40, Arnd Bergmann wrote: > On Thu, Jun 12, 2025, at 09:58, Tomi Valkeinen wrote: >> On 10/06/2025 12:27, Arnd Bergmann wrote: >>> >>> -static void dispc_restore_context(struct dispc_device *dispc) >>> +static noinline_for_stack void dispc_restore_context(struct dispc_device

Re: [PATCH] drm: omapdrm: reduce clang stack usage

2025-06-12 Thread Arnd Bergmann
On Thu, Jun 12, 2025, at 09:58, Tomi Valkeinen wrote: > On 10/06/2025 12:27, Arnd Bergmann wrote: >> >> -static void dispc_restore_context(struct dispc_device *dispc) >> +static noinline_for_stack void dispc_restore_context(struct dispc_device >> *dispc) >> { >> int i, j; >> > > While I

Re: [PATCH] drm: omapdrm: reduce clang stack usage

2025-06-12 Thread Tomi Valkeinen
Hi, On 10/06/2025 12:27, Arnd Bergmann wrote: > From: Arnd Bergmann > > The thread sanitizer makes the stack usage explode from extra variable > spills in dispc_runtime_resume: > > drivers/gpu/drm/omapdrm/dss/dispc.c:4735:27: error: stack frame size (1824) > exceeds limit (1280) in 'dispc_runt

[PATCH] drm: omapdrm: reduce clang stack usage

2025-06-10 Thread Arnd Bergmann
From: Arnd Bergmann The thread sanitizer makes the stack usage explode from extra variable spills in dispc_runtime_resume: drivers/gpu/drm/omapdrm/dss/dispc.c:4735:27: error: stack frame size (1824) exceeds limit (1280) in 'dispc_runtime_resume' [-Werror,-Wframe-larger-than] I could not figure