Re: [Outreachy kernel] [PATCH] drm: nouveau: dispnv50: disp.c: Remove set but unused variables

2021-04-15 Thread Julia Lawall
On Thu, 15 Apr 2021, Fabio M. De Francesco wrote: > On Thursday, April 15, 2021 9:57:07 PM CEST Julia Lawall wrote: > > On Thu, 15 Apr 2021, Fabio M. De Francesco wrote: > > > Removed two set but unused variables. > > > > Would it be useful to use the values? > > > It would be useful if one wan

Re: [Outreachy kernel] [PATCH] drm: nouveau: dispnv50: disp.c: Remove set but unused variables

2021-04-15 Thread Fabio M. De Francesco
On Thursday, April 15, 2021 9:57:07 PM CEST Julia Lawall wrote: > On Thu, 15 Apr 2021, Fabio M. De Francesco wrote: > > Removed two set but unused variables. > > Would it be useful to use the values? > It would be useful if one wants to check returns for errors (which are signaled by res differen

Re: [Outreachy kernel] [PATCH] drm: nouveau: dispnv50: disp.c: Remove set but unused variables

2021-04-15 Thread Julia Lawall
On Thu, 15 Apr 2021, Fabio M. De Francesco wrote: > Removed two set but unused variables. Would it be useful to use the values? julia > > Signed-off-by: Fabio M. De Francesco > --- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > >

[PATCH] drm: nouveau: dispnv50: disp.c: Remove set but unused variables

2021-04-15 Thread Fabio M. De Francesco
Removed two set but unused variables. Signed-off-by: Fabio M. De Francesco --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c index 196612addfd6