[PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-03-19 Thread Daniel Vetter
On Tue, Jan 29, 2013 at 09:10:40AM -0800, Aaron Plattner wrote: > On 01/28/2013 05:38 AM, Rahul Sharma wrote: > >It fixes the issue arises due to passing 'nr_pages' in place of 'nents' to > >sg_alloc_table. When ARM_HAS_SG_CHAIN is disabled, it is causing failure in > >creating SG table for the buf

Re: [PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-03-19 Thread Daniel Vetter
On Tue, Jan 29, 2013 at 09:10:40AM -0800, Aaron Plattner wrote: > On 01/28/2013 05:38 AM, Rahul Sharma wrote: > >It fixes the issue arises due to passing 'nr_pages' in place of 'nents' to > >sg_alloc_table. When ARM_HAS_SG_CHAIN is disabled, it is causing failure in > >creating SG table for the buf

[PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-31 Thread Rahul Sharma
On Thu, Jan 31, 2013 at 5:47 PM, Daniel Vetter wrote: > On Thu, Jan 31, 2013 at 12:54 PM, Rahul Sharma wrote: >> I have parsed the related code and it looks fine to me. I couldn't find >> any code section, expecting sg-tables with single-page sgl entries. I >> just want to ensure again that it do

[PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-31 Thread Rahul Sharma
On Thu, Jan 31, 2013 at 2:23 PM, Daniel Vetter wrote: > On Thu, Jan 31, 2013 at 9:38 AM, Rahul Sharma wrote: >> On Tue, Jan 29, 2013 at 10:40 PM, Aaron Plattner >> wrote: >>> On 01/28/2013 05:38 AM, Rahul Sharma wrote: It fixes the issue arises due to passing 'nr_pages' in place of 'n

[PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-31 Thread Daniel Vetter
On Thu, Jan 31, 2013 at 2:26 PM, Rahul Sharma wrote: >> The other thing is that only doing sg entry coalescing for >> prime/dma_buf will lead to a QA problem, since all the normal sg >> tables still have a 1:1 relationship. So imo the right way to move >> forward with this is to convert the variou

[PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-31 Thread Rahul Sharma
On Tue, Jan 29, 2013 at 10:40 PM, Aaron Plattner wrote: > On 01/28/2013 05:38 AM, Rahul Sharma wrote: >> >> It fixes the issue arises due to passing 'nr_pages' in place of 'nents' to >> sg_alloc_table. When ARM_HAS_SG_CHAIN is disabled, it is causing failure >> in >> creating SG table for the buf

[PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-31 Thread Daniel Vetter
On Thu, Jan 31, 2013 at 12:54 PM, Rahul Sharma wrote: > I have parsed the related code and it looks fine to me. I couldn't find > any code section, expecting sg-tables with single-page sgl entries. I > just want to ensure again that it doesn't cause any side effects on > various platforms. Just c

[PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-31 Thread Daniel Vetter
On Thu, Jan 31, 2013 at 9:38 AM, Rahul Sharma wrote: > On Tue, Jan 29, 2013 at 10:40 PM, Aaron Plattner > wrote: >> On 01/28/2013 05:38 AM, Rahul Sharma wrote: >>> >>> It fixes the issue arises due to passing 'nr_pages' in place of 'nents' to >>> sg_alloc_table. When ARM_HAS_SG_CHAIN is disabled

Re: [PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-31 Thread Daniel Vetter
On Thu, Jan 31, 2013 at 2:26 PM, Rahul Sharma wrote: >> The other thing is that only doing sg entry coalescing for >> prime/dma_buf will lead to a QA problem, since all the normal sg >> tables still have a 1:1 relationship. So imo the right way to move >> forward with this is to convert the variou

Re: [PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-31 Thread Rahul Sharma
On Thu, Jan 31, 2013 at 5:47 PM, Daniel Vetter wrote: > On Thu, Jan 31, 2013 at 12:54 PM, Rahul Sharma wrote: >> I have parsed the related code and it looks fine to me. I couldn't find >> any code section, expecting sg-tables with single-page sgl entries. I >> just want to ensure again that it do

Re: [PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-31 Thread Daniel Vetter
On Thu, Jan 31, 2013 at 12:54 PM, Rahul Sharma wrote: > I have parsed the related code and it looks fine to me. I couldn't find > any code section, expecting sg-tables with single-page sgl entries. I > just want to ensure again that it doesn't cause any side effects on > various platforms. Just c

Re: [PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-31 Thread Rahul Sharma
On Thu, Jan 31, 2013 at 2:23 PM, Daniel Vetter wrote: > On Thu, Jan 31, 2013 at 9:38 AM, Rahul Sharma wrote: >> On Tue, Jan 29, 2013 at 10:40 PM, Aaron Plattner >> wrote: >>> On 01/28/2013 05:38 AM, Rahul Sharma wrote: It fixes the issue arises due to passing 'nr_pages' in place of 'n

Re: [PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-31 Thread Daniel Vetter
On Thu, Jan 31, 2013 at 9:38 AM, Rahul Sharma wrote: > On Tue, Jan 29, 2013 at 10:40 PM, Aaron Plattner wrote: >> On 01/28/2013 05:38 AM, Rahul Sharma wrote: >>> >>> It fixes the issue arises due to passing 'nr_pages' in place of 'nents' to >>> sg_alloc_table. When ARM_HAS_SG_CHAIN is disabled, i

Re: [PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-31 Thread Rahul Sharma
On Tue, Jan 29, 2013 at 10:40 PM, Aaron Plattner wrote: > On 01/28/2013 05:38 AM, Rahul Sharma wrote: >> >> It fixes the issue arises due to passing 'nr_pages' in place of 'nents' to >> sg_alloc_table. When ARM_HAS_SG_CHAIN is disabled, it is causing failure >> in >> creating SG table for the buff

Re: [PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-29 Thread Aaron Plattner
On 01/28/2013 05:38 AM, Rahul Sharma wrote: It fixes the issue arises due to passing 'nr_pages' in place of 'nents' to sg_alloc_table. When ARM_HAS_SG_CHAIN is disabled, it is causing failure in creating SG table for the buffers having more than 204 physical pages i.e. equal to SG_MAX_SINGLE_ALLO

[PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-29 Thread Aaron Plattner
On 01/28/2013 05:38 AM, Rahul Sharma wrote: > It fixes the issue arises due to passing 'nr_pages' in place of 'nents' to > sg_alloc_table. When ARM_HAS_SG_CHAIN is disabled, it is causing failure in > creating SG table for the buffers having more than 204 physical pages i.e. > equal to SG_MAX_SINGL

[PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-29 Thread Rahul Sharma
It fixes the issue arises due to passing 'nr_pages' in place of 'nents' to sg_alloc_table. When ARM_HAS_SG_CHAIN is disabled, it is causing failure in creating SG table for the buffers having more than 204 physical pages i.e. equal to SG_MAX_SINGLE_ALLOC. When using sg_alloc_table_from_pages inter

[PATCH] drm: modify pages_to_sg prime helper to create optimized SG table

2013-01-28 Thread Rahul Sharma
It fixes the issue arises due to passing 'nr_pages' in place of 'nents' to sg_alloc_table. When ARM_HAS_SG_CHAIN is disabled, it is causing failure in creating SG table for the buffers having more than 204 physical pages i.e. equal to SG_MAX_SINGLE_ALLOC. When using sg_alloc_table_from_pages inter