Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-17 Thread Jeff Layton
cher > > Cc: David Airlie ; Daniel Vetter ; > > Deucher, Alexander ; linux- > > ker...@vger.kernel.org; dri-devel@lists.freedesktop.org > > Subject: Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully > > handle NULL state pointer > > > > On Mon, 1

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-17 Thread Jeff Layton
On Mon, 2023-04-17 at 13:29 +0300, Jani Nikula wrote: > On Mon, 17 Apr 2023, Jeff Layton wrote: > > On Mon, 2023-04-17 at 11:44 +0300, Jani Nikula wrote: > > > On Fri, 14 Apr 2023, Lyude Paul wrote: > > > > On Fri, 2023-04-14 at 13:35 +0300, Jani Nikula wrote: > > > > > On Fri, 14 Apr 2023, Jeff

RE: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-17 Thread Lin, Wayne
er.kernel.org; dri-devel@lists.freedesktop.org > Subject: Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully > handle NULL state pointer > > On Mon, 17 Apr 2023, Jeff Layton wrote: > > On Mon, 2023-04-17 at 11:44 +0300, Jani Nikula wrote: > >> On Fri, 14 Apr 2023, Ly

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-17 Thread Jani Nikula
On Mon, 17 Apr 2023, Jeff Layton wrote: > On Mon, 2023-04-17 at 11:44 +0300, Jani Nikula wrote: >> On Fri, 14 Apr 2023, Lyude Paul wrote: >> > On Fri, 2023-04-14 at 13:35 +0300, Jani Nikula wrote: >> > > On Fri, 14 Apr 2023, Jeff Layton wrote: >> > > > On Fri, 2023-04-14 at 04:40 +, Lin, Way

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-17 Thread Jeff Layton
On Mon, 2023-04-17 at 11:44 +0300, Jani Nikula wrote: > On Fri, 14 Apr 2023, Lyude Paul wrote: > > On Fri, 2023-04-14 at 13:35 +0300, Jani Nikula wrote: > > > On Fri, 14 Apr 2023, Jeff Layton wrote: > > > > On Fri, 2023-04-14 at 04:40 +, Lin, Wayne wrote: > > > > > [Public] > > > > > > > > >

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-17 Thread Jani Nikula
we could use mgr->dev >> like the other logging calls do. It's papering over the NULL parameter >> too, but perhaps in a slightly cleaner way... >> >> >> BR, >> Jani. >> >> >> > >> > > > -Original Message- >> > &g

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-14 Thread Lyude Paul
Jani. > > > > > > > > -----Original Message- > > > > From: Alex Deucher > > > > Sent: Thursday, April 13, 2023 8:59 PM > > > > To: Jani Nikula ; Lin, Wayne > > > > > > > > Cc: Jeff Layton ; David Airlie ; >

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-14 Thread Jani Nikula
ani. > >> > -Original Message- >> > From: Alex Deucher >> > Sent: Thursday, April 13, 2023 8:59 PM >> > To: Jani Nikula ; Lin, Wayne >> > >> > Cc: Jeff Layton ; David Airlie ; >> > Daniel Vetter ; Deucher, Alexande

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-14 Thread Jeff Layton
nt: Thursday, April 13, 2023 8:59 PM > > To: Jani Nikula ; Lin, Wayne > > > > Cc: Jeff Layton ; David Airlie ; > > Daniel Vetter ; Deucher, Alexander > > ; linux-ker...@vger.kernel.org; dri- > > de...@lists.freedesktop.org > > Subject: Re: [PATCH] drm: make

RE: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Lin, Wayne
org; dri- > de...@lists.freedesktop.org > Subject: Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully > handle NULL state pointer > > + Wayne > > On Thu, Apr 13, 2023 at 8:31 AM Jani Nikula > wrote: > > > > On Thu, 13 Apr 2023, Jeff Layton wrote: > > &g

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Alex Deucher
+ Wayne On Thu, Apr 13, 2023 at 8:31 AM Jani Nikula wrote: > > On Thu, 13 Apr 2023, Jeff Layton wrote: > > I've been experiencing some intermittent crashes down in the display > > driver code. The symptoms are ususally a line like this in dmesg: > > > > amdgpu :30:00.0: [drm] Failed to c

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Jeff Layton
On Thu, 2023-04-13 at 15:31 +0300, Jani Nikula wrote: > On Thu, 13 Apr 2023, Jeff Layton wrote: > > I've been experiencing some intermittent crashes down in the display > > driver code. The symptoms are ususally a line like this in dmesg: > > > > amdgpu :30:00.0: [drm] Failed to create MS

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Jani Nikula
On Thu, 13 Apr 2023, Jeff Layton wrote: > I've been experiencing some intermittent crashes down in the display > driver code. The symptoms are ususally a line like this in dmesg: > > amdgpu :30:00.0: [drm] Failed to create MST payload for port > 6d3a3885: -5 > > ...followed by an

[PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Jeff Layton
I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg: amdgpu :30:00.0: [drm] Failed to create MST payload for port 6d3a3885: -5 ...followed by an Oops due to a NULL pointer dereference. The real bug