Yeah. Sorry again. I was frustrated. Your email basically said
everything was wrong with my patch. The subject was wrong. The commit
message was too short. The Fixes tag was wrong. The patch wasn't
correct and didn't address the root cause. And then when you mentioned
"bare brain" I misunde
Hi,
I still remember you are helps to review the drm/lsdc patch one years
ago, see [1].
drm/lsdc is the former version of drm/loongson, originally drm/lsdc
are embedded SoCs of Loongson.
[1] https://patchwork.freedesktop.org/patch/471997/?series=99512&rev=5
I haven't forget about you.
Hi,
On 2023/7/18 21:59, Dan Carpenter wrote:
People have suggested that I misread this and that "bare brain" means
through code review instead of testing. In context that seems to make
sense.
Sorry.
Sorry for my broken English, that's really a misunderstanding.
Anyway, the fixes tag is war
Hi,
On 2023/7/18 21:27, Dan Carpenter wrote:
Basically everything in this email was wrong to a kind of shocking
degree. For example, ignoring kmalloc() failure is a bug so the fixes
tag is definitely warranted. But then you called me "bare brained"
which seems like a personal attack
Sorry, t
People have suggested that I misread this and that "bare brain" means
through code review instead of testing. In context that seems to make
sense.
Sorry.
Anyway, the fixes tag is warranted.
> > Even if the fail happened, your patch is not fixing the root problem.
What is the correct fix then?
Basically everything in this email was wrong to a kind of shocking
degree. For example, ignoring kmalloc() failure is a bug so the fixes
tag is definitely warranted. But then you called me "bare brained"
which seems like a personal attack so I'm going to report this as a code
of conduct violation
"drm/loongson: Add a check for lsdc_bo_create() errors"
On 2023/7/18 15:01, Dan Carpenter wrote:
The lsdc_bo_create() function can fail so add a check for that.
Fixes: f39db26c5428 ("drm: Add kms driver for loongson display controller")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/loo
Hi,
Thanks for the patch.
The commit title generally should be 'drm/looongson: Add a check for
lsdc_bo_create() errors'
not 'drm: loongson: '
On 2023/7/18 15:01, Dan Carpenter wrote:
The lsdc_bo_create() function can fail so add a check for that.
Fixes: f39db26c5428 ("drm: Add kms d
The lsdc_bo_create() function can fail so add a check for that.
Fixes: f39db26c5428 ("drm: Add kms driver for loongson display controller")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/loongson/lsdc_ttm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/loongson/lsdc_ttm
