Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-21 Thread Marek Vasut
On 10/21/24 1:48 PM, Maxime Ripard wrote: On Sun, Oct 20, 2024 at 04:49:29AM +0200, Marek Vasut wrote: On 10/19/24 11:49 PM, Kieran Bingham wrote: Quoting Marek Vasut (2024-10-12 21:37:59) On 10/11/24 5:10 AM, Liu Ying wrote: Hi, This Video PLL1 configuration since moved to &media_blk_ctrl

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-21 Thread Marek Vasut
On 10/21/24 1:10 PM, Kieran Bingham wrote: Quoting Marek Vasut (2024-10-20 03:49:29) On 10/19/24 11:49 PM, Kieran Bingham wrote: Quoting Marek Vasut (2024-10-12 21:37:59) On 10/11/24 5:10 AM, Liu Ying wrote: Hi, This Video PLL1 configuration since moved to &media_blk_ctrl {} , but it is st

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-21 Thread Maxime Ripard
On Sun, Oct 20, 2024 at 04:49:29AM +0200, Marek Vasut wrote: > On 10/19/24 11:49 PM, Kieran Bingham wrote: > > Quoting Marek Vasut (2024-10-12 21:37:59) > > > On 10/11/24 5:10 AM, Liu Ying wrote: > > > > > > Hi, > > > > > > > > > > This Video PLL1 configuration since moved to &media_blk_ctrl {} ,

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-21 Thread Kieran Bingham
Quoting Marek Vasut (2024-10-20 03:49:29) > On 10/19/24 11:49 PM, Kieran Bingham wrote: > > Quoting Marek Vasut (2024-10-12 21:37:59) > >> On 10/11/24 5:10 AM, Liu Ying wrote: > >> > >> Hi, > >> > >> This Video PLL1 configuration since moved to &media_blk_ctrl {} , but > >> it is still in

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-19 Thread Marek Vasut
On 10/19/24 11:49 PM, Kieran Bingham wrote: Quoting Marek Vasut (2024-10-12 21:37:59) On 10/11/24 5:10 AM, Liu Ying wrote: Hi, This Video PLL1 configuration since moved to &media_blk_ctrl {} , but it is still in the imx8mp.dtsi . Therefore, to make your panel work at the correct desired pix

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-19 Thread Kieran Bingham
Quoting Marek Vasut (2024-10-12 21:37:59) > On 10/11/24 5:10 AM, Liu Ying wrote: > > Hi, > > This Video PLL1 configuration since moved to &media_blk_ctrl {} , but it > is still in the imx8mp.dtsi . Therefore, to make your panel work at the > correct desired pixel clock frequency

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-12 Thread Marek Vasut
On 10/11/24 5:10 AM, Liu Ying wrote: Hi, This Video PLL1 configuration since moved to &media_blk_ctrl {} , but it is still in the imx8mp.dtsi . Therefore, to make your panel work at the correct desired pixel clock frequency instead of some random one inherited from imx8mp.dtsi, add the follo

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-10 Thread Liu Ying
On 10/11/2024, Marek Vasut wrote: > On 10/10/24 7:31 AM, Liu Ying wrote: > > Hi, Hi, > >>> This Video PLL1 configuration since moved to &media_blk_ctrl {} , but it is >>> still in the imx8mp.dtsi . Therefore, to make your panel work at the >>> correct desired pixel clock frequency instead of

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-10 Thread Marek Vasut
On 10/10/24 7:31 AM, Liu Ying wrote: Hi, This Video PLL1 configuration since moved to &media_blk_ctrl {} , but it is still in the imx8mp.dtsi . Therefore, to make your panel work at the correct desired pixel clock frequency instead of some random one inherited from imx8mp.dtsi, add the follo

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-10 Thread Isaac Scott
On Thu, 2024-10-10 at 16:54 +0100, Isaac Scott wrote: To be clear, my reply applies to the patch referenced by [1] Tested-by: Isaac Scott > On Thu, 2024-10-10 at 13:31 +0800, Liu Ying wrote: > > On 10/09/2024, Marek Vasut wrote: > > > On 10/8/24 12:07 PM, Isaac Scott wrote: > > > > On Mon, 2024

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-10 Thread Isaac Scott
On Thu, 2024-10-10 at 13:31 +0800, Liu Ying wrote: > On 10/09/2024, Marek Vasut wrote: > > On 10/8/24 12:07 PM, Isaac Scott wrote: > > > On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: > > > > On 10/7/24 7:01 PM, Isaac Scott wrote: > > > > > Hi Marek, > > > > > > > > Hi, > > > > > > > > > O

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-09 Thread Liu Ying
On 10/09/2024, Marek Vasut wrote: > On 10/8/24 12:07 PM, Isaac Scott wrote: >> On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: >>> On 10/7/24 7:01 PM, Isaac Scott wrote: Hi Marek, >>> >>> Hi, >>> On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut wrote: > On 6/24/24 11:19 AM, Alexan

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-09 Thread Marek Vasut
On 10/9/24 5:58 PM, Isaac Scott wrote: [...] media_mipi_phy1_ref  0   0    0 23036364 0  0 5  N  deviceless no_co     media_mipi_phy1_ref_root 0   0    0 23036364    0  0 5  N 32ec.blk

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-09 Thread Isaac Scott
On Wed, 2024-10-09 at 17:47 +0200, Marek Vasut wrote: > On 10/9/24 11:55 AM, Isaac Scott wrote: > > On Tue, 2024-10-08 at 23:48 +0200, Marek Vasut wrote: > > > On 10/8/24 12:07 PM, Isaac Scott wrote: > > > > On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: > > > > > On 10/7/24 7:01 PM, Isaac S

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-09 Thread Marek Vasut
On 10/9/24 11:55 AM, Isaac Scott wrote: On Tue, 2024-10-08 at 23:48 +0200, Marek Vasut wrote: On 10/8/24 12:07 PM, Isaac Scott wrote: On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: On 10/7/24 7:01 PM, Isaac Scott wrote: Hi Marek, Hi, On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut w

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-09 Thread Isaac Scott
On Tue, 2024-10-08 at 23:48 +0200, Marek Vasut wrote: > On 10/8/24 12:07 PM, Isaac Scott wrote: > > On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: > > > On 10/7/24 7:01 PM, Isaac Scott wrote: > > > > Hi Marek, > > > > > > Hi, > > > > > > > On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut wro

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-08 Thread Marek Vasut
On 10/8/24 12:07 PM, Isaac Scott wrote: On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: On 10/7/24 7:01 PM, Isaac Scott wrote: Hi Marek, Hi, On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut wrote: On 6/24/24 11:19 AM, Alexander Stein wrote: Am Freitag, 31. Mai 2024, 22:27:21 CEST schr

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-08 Thread Marek Vasut
On 10/8/24 12:07 PM, Isaac Scott wrote: On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: On 10/7/24 7:01 PM, Isaac Scott wrote: Hi Marek, Hi, On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut wrote: On 6/24/24 11:19 AM, Alexander Stein wrote: Am Freitag, 31. Mai 2024, 22:27:21 CEST schr

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-08 Thread Isaac Scott
Hi Marek, On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut wrote: > On 6/24/24 11:19 AM, Alexander Stein wrote: > > Am Freitag, 31. Mai 2024, 22:27:21 CEST schrieb Marek Vasut: > > > In case an upstream bridge modified the required clock frequency > > > in its .atomic_check callback by setting adjus

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-07 Thread Marek Vasut
On 10/7/24 7:01 PM, Isaac Scott wrote: Hi Marek, Hi, On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut wrote: On 6/24/24 11:19 AM, Alexander Stein wrote: Am Freitag, 31. Mai 2024, 22:27:21 CEST schrieb Marek Vasut: In case an upstream bridge modified the required clock frequency in its .atomi

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-07-05 Thread Marek Vasut
On 6/24/24 11:19 AM, Alexander Stein wrote: Am Freitag, 31. Mai 2024, 22:27:21 CEST schrieb Marek Vasut: In case an upstream bridge modified the required clock frequency in its .atomic_check callback by setting adjusted_mode.clock , make sure that clock frequency is generated by the LCDIFv3 bloc

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-06-24 Thread Alexander Stein
Am Freitag, 31. Mai 2024, 22:27:21 CEST schrieb Marek Vasut: > In case an upstream bridge modified the required clock frequency > in its .atomic_check callback by setting adjusted_mode.clock , > make sure that clock frequency is generated by the LCDIFv3 block. > > This is useful e.g. when LCDIFv3

[PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-05-31 Thread Marek Vasut
In case an upstream bridge modified the required clock frequency in its .atomic_check callback by setting adjusted_mode.clock , make sure that clock frequency is generated by the LCDIFv3 block. This is useful e.g. when LCDIFv3 feeds DSIM which feeds TC358767 with (e)DP output, where the TC358767 e