Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-03 Thread Liu Ying
On Tue, 2022-11-01 at 15:04 +0100, Marco Felsch wrote: > Hi Marek, Liu, Hi, > > On 22-10-28, Liu Ying wrote: > > On Fri, 2022-10-28 at 02:03 +0200, Marek Vasut wrote: > > > On 10/27/22 19:47, Marco Felsch wrote: > > > > On 22-10-27, Liu Ying wrote: > > > > > On Thu, 2022-10-27 at 12:03 +0200, Ma

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marco Felsch
On 22-11-01, Marek Vasut wrote: > On 11/1/22 17:51, Marco Felsch wrote: > > On 22-11-01, Marek Vasut wrote: > > > On 11/1/22 17:06, Marco Felsch wrote: > > > > > > Hi, > > > > > > > > > Also I understood the thresholds in such a way, that the FIFO > > > > > > watermark > > > > > > must be higher

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marek Vasut
On 11/1/22 17:51, Marco Felsch wrote: On 22-11-01, Marek Vasut wrote: On 11/1/22 17:06, Marco Felsch wrote: Hi, Also I understood the thresholds in such a way, that the FIFO watermark must be higher but there is no place left when it is set to 3/3. In such case this means that the PANIC will

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marco Felsch
On 22-11-01, Marek Vasut wrote: > On 11/1/22 17:06, Marco Felsch wrote: > > Hi, > > > > > Also I understood the thresholds in such a way, that the FIFO watermark > > > > must be higher but there is no place left when it is set to 3/3. In such > > > > case this means that the PANIC will never left

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marek Vasut
On 11/1/22 17:06, Marco Felsch wrote: Hi, Also I understood the thresholds in such a way, that the FIFO watermark must be higher but there is no place left when it is set to 3/3. In such case this means that the PANIC will never left once it was entered. I think this part is wrong. Consider

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marco Felsch
On 22-11-01, Marek Vasut wrote: > On 11/1/22 15:04, Marco Felsch wrote: > > Hi Marek, Liu, > > Hi, > > [...] > > > > > > Also IMHO the threshold should be taken wisely to not enter panic > > > > > mode > > > > > to early to not block others from the bus e.g. the GPU. > > > > > > > > As far as I

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marek Vasut
On 11/1/22 15:04, Marco Felsch wrote: Hi Marek, Liu, Hi, [...] Also IMHO the threshold should be taken wisely to not enter panic mode to early to not block others from the bus e.g. the GPU. As far as I understand the PANIC0_THRES, both thresholds are really watermarks in the FIFO, 0=EMPTY,

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marco Felsch
Hi Marek, Liu, On 22-10-28, Liu Ying wrote: > On Fri, 2022-10-28 at 02:03 +0200, Marek Vasut wrote: > > On 10/27/22 19:47, Marco Felsch wrote: > > > On 22-10-27, Liu Ying wrote: > > > > On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote: > > > > > On 10/27/22 07:45, Liu Ying wrote: > > > > > >

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Liu Ying
On Fri, 2022-10-28 at 02:03 +0200, Marek Vasut wrote: > On 10/27/22 19:47, Marco Felsch wrote: > > On 22-10-27, Liu Ying wrote: > > > On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote: > > > > On 10/27/22 07:45, Liu Ying wrote: > > > > > > > > Hi, > > > > > > > > [...] > > > > > > > > > > dif

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marek Vasut
On 10/27/22 19:47, Marco Felsch wrote: On 22-10-27, Liu Ying wrote: On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote: On 10/27/22 07:45, Liu Ying wrote: Hi, [...] diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index a5302006c02cd..aee7babb5fa5c 100644

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marco Felsch
On 22-10-27, Liu Ying wrote: > On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote: > > On 10/27/22 07:45, Liu Ying wrote: > > > > Hi, > > > > [...] > > > > > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > > b/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > > index a5302006c02cd..aee7babb5fa5c

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Liu Ying
On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote: > On 10/27/22 07:45, Liu Ying wrote: > > Hi, > > [...] > > > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > b/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > index a5302006c02cd..aee7babb5fa5c 100644 > > > --- a/drivers/gpu/drm/mxsfb/lcdif_km

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marek Vasut
On 10/27/22 07:45, Liu Ying wrote: Hi, [...] diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index a5302006c02cd..aee7babb5fa5c 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -341,6 +341,18 @@ static void lcdif_enab

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marek Vasut
On 10/27/22 10:32, Marco Felsch wrote: Hi, diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index a5302006c02cd..aee7babb5fa5c 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -341,6 +341,18 @@ static void lcdif_enable_

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marco Felsch
On 22-10-27, Marek Vasut wrote: > On 10/27/22 10:13, Marco Felsch wrote: > > Hi, > > [...] > > > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > b/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > index a5302006c02cd..aee7babb5fa5c 100644 > > > --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > +++ b/d

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marek Vasut
On 10/27/22 10:13, Marco Felsch wrote: Hi, [...] diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index a5302006c02cd..aee7babb5fa5c 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -341,6 +341,18 @@ static void lcdif_

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marco Felsch
Hi Marek, On 22-10-26, Marek Vasut wrote: > In case the LCDIFv3 is used to drive a 4k panel via i.MX8MP HDMI bridge, > the LCDIFv3 becomes susceptible to FIFO underflows, which lead to nasty > flicker of the image on the panel, or image being shifted by half frame > horizontally every second frame

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-26 Thread Liu Ying
Hi, On Wed, 2022-10-26 at 23:20 +0200, Marek Vasut wrote: > In case the LCDIFv3 is used to drive a 4k panel via i.MX8MP HDMI bridge, > the LCDIFv3 becomes susceptible to FIFO underflows, which lead to nasty s/lead/leads/ > flicker of the image on the panel, or image being shifted by half frame >

[PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-26 Thread Marek Vasut
In case the LCDIFv3 is used to drive a 4k panel via i.MX8MP HDMI bridge, the LCDIFv3 becomes susceptible to FIFO underflows, which lead to nasty flicker of the image on the panel, or image being shifted by half frame horizontally every second frame. The flicker can be easily triggered by running 3D