Re: [PATCH] drm: kirin: Fix missing clk_disable_unprepare in ade_power_up()

2022-12-05 Thread Yongqin Liu
Hi, John Thanks for sharing this information! Hi, XiaoJing I boot tested this change with hikey and hikey960 android-mainline builds, both could boot to the home screen. But I am not sure what the problem is without this change, so I could not check if this change helps fix any problem, just ch

Re: [PATCH] drm: kirin: Fix missing clk_disable_unprepare in ade_power_up()

2022-12-02 Thread John Stultz
On Fri, Dec 2, 2022 at 12:22 AM Shang XiaoJing wrote: > > The clk_disable_unprepare() should be called in the error handling of > ade_power_up(). So as reset_control_assert(). > > Fixes: 783ad972c9a0 ("drm/hisilicon: Add crtc driver for ADE") > Signed-off-by: Shang XiaoJing Looks reasonable to m

[PATCH] drm: kirin: Fix missing clk_disable_unprepare in ade_power_up()

2022-12-02 Thread Shang XiaoJing
The clk_disable_unprepare() should be called in the error handling of ade_power_up(). So as reset_control_assert(). Fixes: 783ad972c9a0 ("drm/hisilicon: Add crtc driver for ADE") Signed-off-by: Shang XiaoJing --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++ 1 file changed, 3 insertio