RE: [PATCH] drm: imx: ipuv3-plane: fix HDMI cannot work for odd screen resolutions

2024-09-04 Thread Pu, Hui
> On Wed, Sep 04, 2024 at 05:43:15AM +0300, Paul Pu wrote: > > This changes the judgement of if needing to round up the width or not, > > from using the `dp_flow` to the plane's type. > > > > The `dp_flow` can be -22(-EINVAL) even the plane is a PRIMARY one. > > See `client_reg[]` in `ipu-common.c`

RE: [PATCH] drm: imx: ipuv3-plane: fix HDMI cannot work for odd screen resolutions

2024-09-04 Thread Pu, Hui
Hi Liu Ying, Thank you very much for guiding me with so detailed comments. V2 is coming. > Hi Paul, > > Thanks for your patch. > > On 09/04/2024, Paul Pu wrote: > > This changes the judgement of if needing to round up the width or not, > > from using the `dp_flow` to the plane's type. > > > >

Re: [PATCH] drm: imx: ipuv3-plane: fix HDMI cannot work for odd screen resolutions

2024-09-03 Thread Greg KH
On Wed, Sep 04, 2024 at 05:43:15AM +0300, Paul Pu wrote: > This changes the judgement of if needing to round up the width or not, > from using the `dp_flow` to the plane's type. > > The `dp_flow` can be -22(-EINVAL) even the plane is a PRIMARY one. > See `client_reg[]` in `ipu-common.c`. > > [

[PATCH] drm: imx: ipuv3-plane: fix HDMI cannot work for odd screen resolutions

2024-09-03 Thread Paul Pu
This changes the judgement of if needing to round up the width or not, from using the `dp_flow` to the plane's type. The `dp_flow` can be -22(-EINVAL) even the plane is a PRIMARY one. See `client_reg[]` in `ipu-common.c`. [0.605141] [drm:ipu_plane_init] channel 28, dp flow -22, possible_crtcs

Re: [PATCH] drm: imx: ipuv3-plane: fix HDMI cannot work for odd screen resolutions

2024-09-03 Thread Liu Ying
Hi Paul, Thanks for your patch. On 09/04/2024, Paul Pu wrote: > This changes the judgement of if needing to round up the width or not, > from using the `dp_flow` to the plane's type. > > The `dp_flow` can be -22(-EINVAL) even the plane is a PRIMARY one. s/even/even if/ > See `client_reg[]` in