[PATCH] drm: fix off-by-one in logger

2018-02-16 Thread Norbert Manthey
The current implementation will leak a byte to the log via memmove. The specified 27 bytes are off-by-one, as the payload is 25 bytes, and the termination character is only one byte large. To avoid this, factor out the error message, and furthermore make the second parameter of the append_entry fun

Re: [PATCH] drm: fix off-by-one in logger

2018-02-16 Thread David Woodhouse
On Fri, 2018-02-16 at 10:43 +0100, Norbert Manthey wrote: > The current implementation will leak a byte to the log via memmove. The > specified 27 bytes are off-by-one, as the payload is 25 bytes, and the > termination character is only one byte large. To avoid this, factor out > the error messag