[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-12 Thread Inki Dae
2012/11/12 Ville Syrj?l? > On Sat, Nov 10, 2012 at 10:09:02AM +0900, Inki Dae wrote: > > 2012/11/10 Ville Syrj?l? > > > > > On Sat, Nov 10, 2012 at 01:50:53AM +0900, Inki Dae wrote: > > > > 2012/11/9 Ville Syrj?l? > > > > > > > > > On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > > >

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-12 Thread Ville Syrjälä
On Sat, Nov 10, 2012 at 10:09:02AM +0900, Inki Dae wrote: > 2012/11/10 Ville Syrj?l? > > > On Sat, Nov 10, 2012 at 01:50:53AM +0900, Inki Dae wrote: > > > 2012/11/9 Ville Syrj?l? > > > > > > > On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > > > > > 2012/11/9 Ville Syrj?l? > > > > >

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-12 Thread Inki Dae
2012/11/12 Ville Syrjälä > On Sat, Nov 10, 2012 at 10:09:02AM +0900, Inki Dae wrote: > > 2012/11/10 Ville Syrjälä > > > > > On Sat, Nov 10, 2012 at 01:50:53AM +0900, Inki Dae wrote: > > > > 2012/11/9 Ville Syrjälä > > > > > > > > > On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > > >

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-12 Thread Ville Syrjälä
On Sat, Nov 10, 2012 at 10:09:02AM +0900, Inki Dae wrote: > 2012/11/10 Ville Syrjälä > > > On Sat, Nov 10, 2012 at 01:50:53AM +0900, Inki Dae wrote: > > > 2012/11/9 Ville Syrjälä > > > > > > > On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > > > > > 2012/11/9 Ville Syrjälä > > > > >

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-10 Thread Inki Dae
2012/11/10 Ville Syrj?l? > On Sat, Nov 10, 2012 at 01:50:53AM +0900, Inki Dae wrote: > > 2012/11/9 Ville Syrj?l? > > > > > On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > > > > 2012/11/9 Ville Syrj?l? > > > > > > > > > On Fri, Nov 09, 2012 at 09:41:19PM +0900, Inki Dae wrote: > > >

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-10 Thread Inki Dae
2012. 11. 10. ?? 2:10 Rob Clark ??: > On Fri, Nov 9, 2012 at 1:39 AM, Inki Dae wrote: >> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h >> index 3fa18b7..92889be 100644 >> --- a/include/drm/drm_crtc.h >> +++ b/include/drm/drm_crtc.h >> @@ -256,6 +256,7 @@ struct drm_framebuffer

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-10 Thread Inki Dae
2012/11/9 Rob Clark > On Fri, Nov 9, 2012 at 1:39 AM, Inki Dae wrote: > > This patch fixes access issue to invalid memory region. > > > > crtc had only one drm_framebuffer object so when framebuffer > > cleanup was requested after page flip, it'd try to disable > > hardware overlay to current cr

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-10 Thread Inki Dae
2012/11/9 Ville Syrj?l? > On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > > 2012/11/9 Ville Syrj?l? > > > > > On Fri, Nov 09, 2012 at 09:41:19PM +0900, Inki Dae wrote: > > > > 2012/11/9 Ville Syrj?l? > > > > > > > > > On Fri, Nov 09, 2012 at 04:39:30PM +0900, Inki Dae wrote: > > > >

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Inki Dae
2012/11/9 Ville Syrj?l? > On Fri, Nov 09, 2012 at 09:41:19PM +0900, Inki Dae wrote: > > 2012/11/9 Ville Syrj?l? > > > > > On Fri, Nov 09, 2012 at 04:39:30PM +0900, Inki Dae wrote: > > > > This patch fixes access issue to invalid memory region. > > > > > > > > crtc had only one drm_framebuffer ob

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Inki Dae
2012/11/9 Ville Syrj?l? > On Fri, Nov 09, 2012 at 04:39:30PM +0900, Inki Dae wrote: > > This patch fixes access issue to invalid memory region. > > > > crtc had only one drm_framebuffer object so when framebuffer > > cleanup was requested after page flip, it'd try to disable > > hardware overlay

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Ville Syrjälä
On Sat, Nov 10, 2012 at 01:50:53AM +0900, Inki Dae wrote: > 2012/11/9 Ville Syrj?l? > > > On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > > > 2012/11/9 Ville Syrj?l? > > > > > > > On Fri, Nov 09, 2012 at 09:41:19PM +0900, Inki Dae wrote: > > > > > 2012/11/9 Ville Syrj?l? > > > > > >

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Inki Dae
2012/11/9 Prathyush K > > On Fri, Nov 9, 2012 at 1:09 PM, Inki Dae wrote: > >> This patch fixes access issue to invalid memory region. >> >> crtc had only one drm_framebuffer object so when framebuffer >> cleanup was requested after page flip, it'd try to disable >> hardware overlay to current c

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Inki Dae
2012/11/10 Ville Syrjälä > On Sat, Nov 10, 2012 at 01:50:53AM +0900, Inki Dae wrote: > > 2012/11/9 Ville Syrjälä > > > > > On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > > > > 2012/11/9 Ville Syrjälä > > > > > > > > > On Fri, Nov 09, 2012 at 09:41:19PM +0900, Inki Dae wrote: > > >

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Inki Dae
This patch fixes access issue to invalid memory region. crtc had only one drm_framebuffer object so when framebuffer cleanup was requested after page flip, it'd try to disable hardware overlay to current crtc. But if current crtc points to another drm_framebuffer, This may induce invalid memory ac

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Ville Syrjälä
On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > 2012/11/9 Ville Syrj?l? > > > On Fri, Nov 09, 2012 at 09:41:19PM +0900, Inki Dae wrote: > > > 2012/11/9 Ville Syrj?l? > > > > > > > On Fri, Nov 09, 2012 at 04:39:30PM +0900, Inki Dae wrote: > > > > > This patch fixes access issue to inv

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Ville Syrjälä
On Fri, Nov 09, 2012 at 09:41:19PM +0900, Inki Dae wrote: > 2012/11/9 Ville Syrj?l? > > > On Fri, Nov 09, 2012 at 04:39:30PM +0900, Inki Dae wrote: > > > This patch fixes access issue to invalid memory region. > > > > > > crtc had only one drm_framebuffer object so when framebuffer > > > cleanup

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Prathyush K
On Fri, Nov 9, 2012 at 1:09 PM, Inki Dae wrote: > This patch fixes access issue to invalid memory region. > > crtc had only one drm_framebuffer object so when framebuffer > cleanup was requested after page flip, it'd try to disable > hardware overlay to current crtc. > But if current crtc points

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Ville Syrjälä
On Fri, Nov 09, 2012 at 04:39:30PM +0900, Inki Dae wrote: > This patch fixes access issue to invalid memory region. > > crtc had only one drm_framebuffer object so when framebuffer > cleanup was requested after page flip, it'd try to disable > hardware overlay to current crtc. > But if current crt

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Rob Clark
On Fri, Nov 9, 2012 at 1:39 AM, Inki Dae wrote: > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index 3fa18b7..92889be 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -256,6 +256,7 @@ struct drm_framebuffer { > struct kref refcount; > stru

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Rob Clark
On Fri, Nov 9, 2012 at 10:56 AM, Inki Dae wrote: > > > 2012/11/9 Rob Clark >> >> On Fri, Nov 9, 2012 at 1:39 AM, Inki Dae wrote: >> > This patch fixes access issue to invalid memory region. >> > >> > crtc had only one drm_framebuffer object so when framebuffer >> > cleanup was requested after pa

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Rob Clark
On Fri, Nov 9, 2012 at 10:50 AM, Inki Dae wrote: > I don't think so. let's see it again. below is my idea AND the reason I > posted this patch. > Original codes, > gem alloc(gem0); > -> gem0 refcount = 1 > gem0 mmap > -> gem0 refcount = 2 > gem alloc(gem1); > -> gem1 refcount =1 > gem1 mmap > -> g

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Ville Syrjälä
On Sat, Nov 10, 2012 at 01:50:53AM +0900, Inki Dae wrote: > 2012/11/9 Ville Syrjälä > > > On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > > > 2012/11/9 Ville Syrjälä > > > > > > > On Fri, Nov 09, 2012 at 09:41:19PM +0900, Inki Dae wrote: > > > > > 2012/11/9 Ville Syrjälä > > > > > >

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Inki Dae
2012. 11. 10. 오전 2:10 Rob Clark 작성: > On Fri, Nov 9, 2012 at 1:39 AM, Inki Dae wrote: >> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h >> index 3fa18b7..92889be 100644 >> --- a/include/drm/drm_crtc.h >> +++ b/include/drm/drm_crtc.h >> @@ -256,6 +256,7 @@ struct drm_framebuffer

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Rob Clark
On Fri, Nov 9, 2012 at 1:39 AM, Inki Dae wrote: > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index 3fa18b7..92889be 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -256,6 +256,7 @@ struct drm_framebuffer { > struct kref refcount; > stru

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Rob Clark
On Fri, Nov 9, 2012 at 10:56 AM, Inki Dae wrote: > > > 2012/11/9 Rob Clark >> >> On Fri, Nov 9, 2012 at 1:39 AM, Inki Dae wrote: >> > This patch fixes access issue to invalid memory region. >> > >> > crtc had only one drm_framebuffer object so when framebuffer >> > cleanup was requested after pa

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Rob Clark
On Fri, Nov 9, 2012 at 10:50 AM, Inki Dae wrote: > I don't think so. let's see it again. below is my idea AND the reason I > posted this patch. > Original codes, > gem alloc(gem0); > -> gem0 refcount = 1 > gem0 mmap > -> gem0 refcount = 2 > gem alloc(gem1); > -> gem1 refcount =1 > gem1 mmap > -> g

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Inki Dae
2012/11/9 Rob Clark > On Fri, Nov 9, 2012 at 1:39 AM, Inki Dae wrote: > > This patch fixes access issue to invalid memory region. > > > > crtc had only one drm_framebuffer object so when framebuffer > > cleanup was requested after page flip, it'd try to disable > > hardware overlay to current cr

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Inki Dae
2012/11/9 Ville Syrjälä > On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > > 2012/11/9 Ville Syrjälä > > > > > On Fri, Nov 09, 2012 at 09:41:19PM +0900, Inki Dae wrote: > > > > 2012/11/9 Ville Syrjälä > > > > > > > > > On Fri, Nov 09, 2012 at 04:39:30PM +0900, Inki Dae wrote: > > > >

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Rob Clark
On Fri, Nov 9, 2012 at 1:39 AM, Inki Dae wrote: > This patch fixes access issue to invalid memory region. > > crtc had only one drm_framebuffer object so when framebuffer > cleanup was requested after page flip, it'd try to disable > hardware overlay to current crtc. > But if current crtc points t

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Rob Clark
On Fri, Nov 9, 2012 at 1:39 AM, Inki Dae wrote: > This patch fixes access issue to invalid memory region. > > crtc had only one drm_framebuffer object so when framebuffer > cleanup was requested after page flip, it'd try to disable > hardware overlay to current crtc. > But if current crtc points t

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Ville Syrjälä
On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > 2012/11/9 Ville Syrjälä > > > On Fri, Nov 09, 2012 at 09:41:19PM +0900, Inki Dae wrote: > > > 2012/11/9 Ville Syrjälä > > > > > > > On Fri, Nov 09, 2012 at 04:39:30PM +0900, Inki Dae wrote: > > > > > This patch fixes access issue to inv

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Inki Dae
2012/11/9 Ville Syrjälä > On Fri, Nov 09, 2012 at 09:41:19PM +0900, Inki Dae wrote: > > 2012/11/9 Ville Syrjälä > > > > > On Fri, Nov 09, 2012 at 04:39:30PM +0900, Inki Dae wrote: > > > > This patch fixes access issue to invalid memory region. > > > > > > > > crtc had only one drm_framebuffer ob

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Ville Syrjälä
On Fri, Nov 09, 2012 at 09:41:19PM +0900, Inki Dae wrote: > 2012/11/9 Ville Syrjälä > > > On Fri, Nov 09, 2012 at 04:39:30PM +0900, Inki Dae wrote: > > > This patch fixes access issue to invalid memory region. > > > > > > crtc had only one drm_framebuffer object so when framebuffer > > > cleanup

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Inki Dae
2012/11/9 Ville Syrjälä > On Fri, Nov 09, 2012 at 04:39:30PM +0900, Inki Dae wrote: > > This patch fixes access issue to invalid memory region. > > > > crtc had only one drm_framebuffer object so when framebuffer > > cleanup was requested after page flip, it'd try to disable > > hardware overlay

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Ville Syrjälä
On Fri, Nov 09, 2012 at 04:39:30PM +0900, Inki Dae wrote: > This patch fixes access issue to invalid memory region. > > crtc had only one drm_framebuffer object so when framebuffer > cleanup was requested after page flip, it'd try to disable > hardware overlay to current crtc. > But if current crt

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Inki Dae
2012/11/9 Prathyush K > > On Fri, Nov 9, 2012 at 1:09 PM, Inki Dae wrote: > >> This patch fixes access issue to invalid memory region. >> >> crtc had only one drm_framebuffer object so when framebuffer >> cleanup was requested after page flip, it'd try to disable >> hardware overlay to current c

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Prathyush K
On Fri, Nov 9, 2012 at 1:09 PM, Inki Dae wrote: > This patch fixes access issue to invalid memory region. > > crtc had only one drm_framebuffer object so when framebuffer > cleanup was requested after page flip, it'd try to disable > hardware overlay to current crtc. > But if current crtc points

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-08 Thread Inki Dae
This patch fixes access issue to invalid memory region. crtc had only one drm_framebuffer object so when framebuffer cleanup was requested after page flip, it'd try to disable hardware overlay to current crtc. But if current crtc points to another drm_framebuffer, This may induce invalid memory ac