Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-14 Thread Romain Perier
Hi, Le 13/03/2017 à 19:49, Jose Abreu a écrit : > Hi Russell, > > > On 13-03-2017 13:10, Russell King - ARM Linux wrote: >> On Mon, Mar 13, 2017 at 12:55:58PM +, Jose Abreu wrote: >>> Hi, >>> >>> >>> On 13-03-2017 09:36, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 10:27:08AM

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-14 Thread Neil Armstrong
On 03/14/2017 08:53 AM, Romain Perier wrote: > Hi, > > > Le 13/03/2017 à 19:49, Jose Abreu a écrit : >> Hi Russell, >> >> >> On 13-03-2017 13:10, Russell King - ARM Linux wrote: >>> On Mon, Mar 13, 2017 at 12:55:58PM +, Jose Abreu wrote: Hi, On 13-03-2017 09:36, Russell Ki

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-13 Thread Jose Abreu
Hi Russell, On 13-03-2017 13:10, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 12:55:58PM +, Jose Abreu wrote: >> Hi, >> >> >> On 13-03-2017 09:36, Russell King - ARM Linux wrote: >>> On Mon, Mar 13, 2017 at 10:27:08AM +0100, Neil Armstrong wrote: On 03/10/2017 10:35 AM, Roma

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-13 Thread Russell King - ARM Linux
On Mon, Mar 13, 2017 at 12:55:58PM +, Jose Abreu wrote: > Hi, > > > On 13-03-2017 09:36, Russell King - ARM Linux wrote: > > On Mon, Mar 13, 2017 at 10:27:08AM +0100, Neil Armstrong wrote: > >> On 03/10/2017 10:35 AM, Romain Perier wrote: > >>> Currently, the audio sampler clock is enabled fr

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-13 Thread Russell King - ARM Linux
On Mon, Mar 13, 2017 at 10:27:08AM +0100, Neil Armstrong wrote: > On 03/10/2017 10:35 AM, Romain Perier wrote: > > Currently, the audio sampler clock is enabled from dw_hdmi_setup() at > > step E. and is kept enabled for later use. This clock should be enabled > > and disabled along with the actual

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-13 Thread Jose Abreu
Hi, On 13-03-2017 09:36, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 10:27:08AM +0100, Neil Armstrong wrote: >> On 03/10/2017 10:35 AM, Romain Perier wrote: >>> Currently, the audio sampler clock is enabled from dw_hdmi_setup() at >>> step E. and is kept enabled for later use. This

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-13 Thread Neil Armstrong
On 03/10/2017 10:35 AM, Romain Perier wrote: > Currently, the audio sampler clock is enabled from dw_hdmi_setup() at > step E. and is kept enabled for later use. This clock should be enabled > and disabled along with the actual audio stream and not always on (that > is bad for PM). Futhermore, this

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-11 Thread Romain Perier
Hello, Le 10/03/2017 à 12:15, Russell King - ARM Linux a écrit : > On Fri, Mar 10, 2017 at 11:58:19AM +0100, Romain Perier wrote: >> Hello, >> >> Le 10/03/2017 à 11:27, Russell King - ARM Linux a écrit : >>> I also would not think that it's platform specific - remember that >>> this is Designware

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-11 Thread Romain Perier
Hello, Le 10/03/2017 à 10:46, Russell King - ARM Linux a écrit : > On Fri, Mar 10, 2017 at 10:35:09AM +0100, Romain Perier wrote: >> Currently, the audio sampler clock is enabled from dw_hdmi_setup() at >> step E. and is kept enabled for later use. This clock should be enabled >> and disabled alon

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-11 Thread Russell King - ARM Linux
On Fri, Mar 10, 2017 at 11:21:53AM +0100, Romain Perier wrote: > Hello, > > Le 10/03/2017 à 10:46, Russell King - ARM Linux a écrit : > > On Fri, Mar 10, 2017 at 10:35:09AM +0100, Romain Perier wrote: > >> Currently, the audio sampler clock is enabled from dw_hdmi_setup() at > >> step E. and is ke

[PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-11 Thread Romain Perier
Currently, the audio sampler clock is enabled from dw_hdmi_setup() at step E. and is kept enabled for later use. This clock should be enabled and disabled along with the actual audio stream and not always on (that is bad for PM). Futhermore, this might cause sound glitches with some HDMI devices, a

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-11 Thread Russell King - ARM Linux
On Fri, Mar 10, 2017 at 11:58:19AM +0100, Romain Perier wrote: > Hello, > > Le 10/03/2017 à 11:27, Russell King - ARM Linux a écrit : > > I also would not think that it's platform specific - remember that > > this is Designware IP, and it's likely that other platforms with > > exactly the same IP

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-11 Thread Romain Perier
Hello, Le 10/03/2017 à 11:27, Russell King - ARM Linux a écrit : > On Fri, Mar 10, 2017 at 11:21:53AM +0100, Romain Perier wrote: >> Hello, >> >> Le 10/03/2017 à 10:46, Russell King - ARM Linux a écrit : >>> On Fri, Mar 10, 2017 at 10:35:09AM +0100, Romain Perier wrote: Currently, the audio

Re: [PATCH] drm: dw_hdmi: Gate audio sampler clock from the enablement functions

2017-03-11 Thread Russell King - ARM Linux
On Fri, Mar 10, 2017 at 10:35:09AM +0100, Romain Perier wrote: > Currently, the audio sampler clock is enabled from dw_hdmi_setup() at > step E. and is kept enabled for later use. This clock should be enabled > and disabled along with the actual audio stream and not always on (that > is bad for PM)