Re: [PATCH] drm: drm_printer: add __printf validation

2017-02-26 Thread Daniel Vetter
On Tue, Feb 21, 2017 at 01:18:03AM -0800, Joe Perches wrote: > On Tue, 2017-02-21 at 11:02 +0200, Jani Nikula wrote: > > On Tue, 21 Feb 2017, Joe Perches wrote: > > > On Tue, 2017-02-21 at 10:26 +0200, Jani Nikula wrote: > > > > You know how this stuff works, please split it up to get the stuff >

Re: [PATCH] drm: drm_printer: add __printf validation

2017-02-21 Thread Joe Perches
On Tue, 2017-02-21 at 11:02 +0200, Jani Nikula wrote: > On Tue, 21 Feb 2017, Joe Perches wrote: > > On Tue, 2017-02-21 at 10:26 +0200, Jani Nikula wrote: > > > You know how this stuff works, please split it up to get the stuff > > > merged. > > > > Quite well actually. > > > > Fix it as you thin

Re: [PATCH] drm: drm_printer: add __printf validation

2017-02-21 Thread Jani Nikula
On Tue, 21 Feb 2017, Joe Perches wrote: > On Tue, 2017-02-21 at 10:26 +0200, Jani Nikula wrote: >> You know how this stuff works, please split it up to get the stuff >> merged. > > Quite well actually. > > Fix it as you think appropriate. > But in any case, fix it. Yes, I'm sure someone will even

Re: [PATCH] drm: drm_printer: add __printf validation

2017-02-21 Thread Joe Perches
On Tue, 2017-02-21 at 10:26 +0200, Jani Nikula wrote: > You know how this stuff works, please split it up to get the stuff > merged. Quite well actually. Fix it as you think appropriate. But in any case, fix it. ___ dri-devel mailing list dri-devel@list

Re: [PATCH] drm: drm_printer: add __printf validation

2017-02-21 Thread Jani Nikula
On Mon, 20 Feb 2017, Joe Perches wrote: > On Mon, 2017-02-20 at 12:17 +, Eric Engestrom wrote: >> On Wednesday, 2017-02-15 15:33:18 -0800, Joe Perches wrote: >> > drm_printf does not currently use the compiler to verify >> > format and arguments. Make it do so. >> > >> > Miscellanea: >> > >

Re: [PATCH] drm: drm_printer: add __printf validation

2017-02-20 Thread Joe Perches
On Mon, 2017-02-20 at 12:17 +, Eric Engestrom wrote: > On Wednesday, 2017-02-15 15:33:18 -0800, Joe Perches wrote: > > drm_printf does not currently use the compiler to verify > > format and arguments. Make it do so. > > > > Miscellanea: > > > > o Add appropriate #include files for __printf

Re: [PATCH] drm: drm_printer: add __printf validation

2017-02-20 Thread Eric Engestrom
On Wednesday, 2017-02-15 15:33:18 -0800, Joe Perches wrote: > drm_printf does not currently use the compiler to verify > format and arguments. Make it do so. > > Miscellanea: > > o Add appropriate #include files for __printf and struct va_format > o Convert dev_printk to dev_info I think these

[PATCH] drm: drm_printer: add __printf validation

2017-02-15 Thread Joe Perches
drm_printf does not currently use the compiler to verify format and arguments. Make it do so. Miscellanea: o Add appropriate #include files for __printf and struct va_format o Convert dev_printk to dev_info Signed-off-by: Joe Perches --- drivers/gpu/drm/drm_print.c | 2 +- include/drm/drm_pri