Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-07 Thread Andrzej Hajda
On 05.02.2018 19:07, Thierry Reding wrote: > On Mon, Feb 05, 2018 at 06:39:05PM +0100, Lucas Stach wrote: >> Am Montag, den 05.02.2018, 18:33 +0100 schrieb Thierry Reding: >>> On Mon, Feb 05, 2018 at 05:11:30PM +0100, Thierry Reding wrote: On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Redi

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-05 Thread Thierry Reding
On Mon, Feb 05, 2018 at 06:39:05PM +0100, Lucas Stach wrote: > Am Montag, den 05.02.2018, 18:33 +0100 schrieb Thierry Reding: > > On Mon, Feb 05, 2018 at 05:11:30PM +0100, Thierry Reding wrote: > > > On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Reding wrote: > > > > On Wed, Apr 05, 2017 at 10:

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-05 Thread Lucas Stach
Am Montag, den 05.02.2018, 18:33 +0100 schrieb Thierry Reding: > On Mon, Feb 05, 2018 at 05:11:30PM +0100, Thierry Reding wrote: > > On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Reding wrote: > > > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: > > > > Hi Rob, > > > > > > > > Am

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-05 Thread Thierry Reding
On Mon, Feb 05, 2018 at 05:11:30PM +0100, Thierry Reding wrote: > On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Reding wrote: > > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: > > > Hi Rob, > > > > > > Am Mittwoch, den 29.03.2017, 08:56 -0500 schrieb Rob Herring: > > > > On Mon,

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-05 Thread Thierry Reding
On Mon, Feb 05, 2018 at 05:29:09PM +0100, Lucas Stach wrote: > Am Montag, den 05.02.2018, 17:11 +0100 schrieb Thierry Reding: > > On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Reding wrote: > > > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: > > > > Hi Rob, > > > > > > > > Am Mi

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-05 Thread Lucas Stach
Am Montag, den 05.02.2018, 17:11 +0100 schrieb Thierry Reding: > On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Reding wrote: > > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: > > > Hi Rob, > > > > > > Am Mittwoch, den 29.03.2017, 08:56 -0500 schrieb Rob Herring: > > > > On Mon,

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-05 Thread Thierry Reding
On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Reding wrote: > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: > > Hi Rob, > > > > Am Mittwoch, den 29.03.2017, 08:56 -0500 schrieb Rob Herring: > > > On Mon, Jan 23, 2017 at 10:33 AM, Thierry Reding > > > wrote: > > > > On Fri, Jan

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2017-11-20 Thread Andrzej Hajda
On 20.11.2017 08:54, Daniel Vetter wrote: > On Tue, Nov 14, 2017 at 03:34:19PM +0100, Andrzej Hajda wrote: >> On 05.04.2017 14:04, Thierry Reding wrote: >>> On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: Hi Rob, Am Mittwoch, den 29.03.2017, 08:56 -0500 schrieb Rob Herri

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2017-11-19 Thread Daniel Vetter
On Tue, Nov 14, 2017 at 03:34:19PM +0100, Andrzej Hajda wrote: > On 05.04.2017 14:04, Thierry Reding wrote: > > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: > >> Hi Rob, > >> > >> Am Mittwoch, den 29.03.2017, 08:56 -0500 schrieb Rob Herring: > >>> On Mon, Jan 23, 2017 at 10:33 AM, T

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2017-11-14 Thread Andrzej Hajda
On 05.04.2017 14:04, Thierry Reding wrote: > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: >> Hi Rob, >> >> Am Mittwoch, den 29.03.2017, 08:56 -0500 schrieb Rob Herring: >>> On Mon, Jan 23, 2017 at 10:33 AM, Thierry Reding >>> wrote: On Fri, Jan 13, 2017 at 06:36:30PM +0100, Lu

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2017-04-05 Thread Thierry Reding
On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: > Hi Rob, > > Am Mittwoch, den 29.03.2017, 08:56 -0500 schrieb Rob Herring: > > On Mon, Jan 23, 2017 at 10:33 AM, Thierry Reding > > wrote: > > > On Fri, Jan 13, 2017 at 06:36:30PM +0100, Lucas Stach wrote: > > >> The i2c adapter on DP

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2017-04-05 Thread Lucas Stach
Hi Rob, Am Mittwoch, den 29.03.2017, 08:56 -0500 schrieb Rob Herring: > On Mon, Jan 23, 2017 at 10:33 AM, Thierry Reding > wrote: > > On Fri, Jan 13, 2017 at 06:36:30PM +0100, Lucas Stach wrote: > >> The i2c adapter on DP AUX is purely a software construct. Linking > >> it to the device node of t

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2017-03-29 Thread Rob Herring
On Mon, Jan 23, 2017 at 10:33 AM, Thierry Reding wrote: > On Fri, Jan 13, 2017 at 06:36:30PM +0100, Lucas Stach wrote: >> The i2c adapter on DP AUX is purely a software construct. Linking >> it to the device node of the parent device is wrong, as it leads to >> 2 devices sharing the same device no

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2017-01-23 Thread Lucas Stach
Am Montag, den 23.01.2017, 17:33 +0100 schrieb Thierry Reding: > On Fri, Jan 13, 2017 at 06:36:30PM +0100, Lucas Stach wrote: > > The i2c adapter on DP AUX is purely a software construct. Linking > > it to the device node of the parent device is wrong, as it leads to > > 2 devices sharing the same

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2017-01-23 Thread Thierry Reding
On Fri, Jan 13, 2017 at 06:36:30PM +0100, Lucas Stach wrote: > The i2c adapter on DP AUX is purely a software construct. Linking > it to the device node of the parent device is wrong, as it leads to > 2 devices sharing the same device node, which is bad practice, as Who says that two devices can't

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2017-01-23 Thread Daniel Vetter
On Fri, Jan 13, 2017 at 06:36:30PM +0100, Lucas Stach wrote: > The i2c adapter on DP AUX is purely a software construct. Linking > it to the device node of the parent device is wrong, as it leads to > 2 devices sharing the same device node, which is bad practice, as > well as the i2c trying to popu

[PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2017-01-13 Thread Lucas Stach
The i2c adapter on DP AUX is purely a software construct. Linking it to the device node of the parent device is wrong, as it leads to 2 devices sharing the same device node, which is bad practice, as well as the i2c trying to populate children of the i2c adapter by looking at the child device nodes