Re: [PATCH] drm: document DRM_MODE_PAGE_FLIP_EVENT interactions with atomic

2025-04-15 Thread Daniel Stone
On Mon, 14 Apr 2025 at 09:24, Simon Ser wrote: > On Friday, January 17th, 2025 at 12:15, Pekka Paalanen > wrote: > > Wasn't this also conditional on the DRM_CAP_CRTC_IN_VBLANK_EVENT or did > > userspace really need to count the events even without it? > > DRM_CAP_CRTC_IN_VBLANK_EVENT is uncondit

Re: [PATCH] drm: document DRM_MODE_PAGE_FLIP_EVENT interactions with atomic

2025-04-14 Thread Simon Ser
On Friday, January 17th, 2025 at 12:15, Pekka Paalanen wrote: > On Thu, 16 Jan 2025 16:25:35 + > Simon Ser cont...@emersion.fr wrote: > > > It's not obvious off-hand which CRTCs will get a page-flip event > > when using this flag in an atomic commit, because it's all > > implicitly implied

Re: [PATCH] drm: document DRM_MODE_PAGE_FLIP_EVENT interactions with atomic

2025-01-17 Thread Ville Syrjälä
On Fri, Jan 17, 2025 at 11:40:15AM +, Simon Ser wrote: > On Friday, January 17th, 2025 at 12:32, Ville Syrjälä > wrote: > > > > + * When used with atomic uAPI, one event will be delivered per CRTC > > > included in > > > + * the atomic commit. A CRTC is included in an atomic commit if one o

Re: [PATCH] drm: document DRM_MODE_PAGE_FLIP_EVENT interactions with atomic

2025-01-17 Thread Simon Ser
On Friday, January 17th, 2025 at 12:32, Ville Syrjälä wrote: > > + * When used with atomic uAPI, one event will be delivered per CRTC > > included in > > + * the atomic commit. A CRTC is included in an atomic commit if one of its > > + * properties is set, or if a property is set on a connector

Re: [PATCH] drm: document DRM_MODE_PAGE_FLIP_EVENT interactions with atomic

2025-01-17 Thread Ville Syrjälä
On Thu, Jan 16, 2025 at 04:25:35PM +, Simon Ser wrote: > It's not obvious off-hand which CRTCs will get a page-flip event > when using this flag in an atomic commit, because it's all > implicitly implied based on the contents of the atomic commit. > Document requirements for using this flag and

Re: [PATCH] drm: document DRM_MODE_PAGE_FLIP_EVENT interactions with atomic

2025-01-17 Thread Pekka Paalanen
On Thu, 16 Jan 2025 16:25:35 + Simon Ser wrote: > It's not obvious off-hand which CRTCs will get a page-flip event > when using this flag in an atomic commit, because it's all > implicitly implied based on the contents of the atomic commit. > Document requirements for using this flag and >

[PATCH] drm: document DRM_MODE_PAGE_FLIP_EVENT interactions with atomic

2025-01-16 Thread Simon Ser
It's not obvious off-hand which CRTCs will get a page-flip event when using this flag in an atomic commit, because it's all implicitly implied based on the contents of the atomic commit. Document requirements for using this flag and Note, because prepare_signaling() runs right after drm_atomic_set