Re: [PATCH] drm: document DRM_IOCTL_MODE_GETFB2

2021-11-15 Thread Simon Ser
On Monday, November 15th, 2021 at 15:20, Daniel Vetter wrote: > On Mon, Nov 15, 2021 at 12:09:47PM +, Simon Ser wrote: > > On Thursday, November 11th, 2021 at 12:50, Daniel Stone > > wrote: > > > > > In fairness it is perfectly clear, it's just that I never considered > > > calling it witho

Re: [PATCH] drm: document DRM_IOCTL_MODE_GETFB2

2021-11-15 Thread Daniel Vetter
On Mon, Nov 15, 2021 at 12:09:47PM +, Simon Ser wrote: > On Thursday, November 11th, 2021 at 12:50, Daniel Stone > wrote: > > > In fairness it is perfectly clear, it's just that I never considered > > calling it without master/admin because why would you ever do that? > > FWIW, drm_info doe

Re: [PATCH] drm: document DRM_IOCTL_MODE_GETFB2

2021-11-15 Thread Simon Ser
On Thursday, November 11th, 2021 at 12:50, Daniel Stone wrote: > In fairness it is perfectly clear, it's just that I never considered > calling it without master/admin because why would you ever do that? FWIW, drm_info does it to display the current buffers metadata. Pretty useful when debuggin

Re: [PATCH] drm: document DRM_IOCTL_MODE_GETFB2

2021-11-11 Thread Daniel Stone
On Tue, 9 Nov 2021 at 08:56, Simon Ser wrote: > There are a few details specific to the GETFB2 IOCTL. > > It's not immediately clear how user-space should check for the > number of planes. Suggest using the pitches field. In fairness it is perfectly clear, it's just that I never considered callin

Re: [PATCH] drm: document DRM_IOCTL_MODE_GETFB2

2021-11-11 Thread Pekka Paalanen
On Tue, 9 Nov 2021 10:24:33 +0100 Daniel Vetter wrote: > On Tue, Nov 09, 2021 at 08:56:10AM +, Simon Ser wrote: > > There are a few details specific to the GETFB2 IOCTL. > > > > It's not immediately clear how user-space should check for the > > number of planes. Suggest using the pitches fie

Re: [PATCH] drm: document DRM_IOCTL_MODE_GETFB2

2021-11-09 Thread Daniel Vetter
On Tue, Nov 09, 2021 at 09:29:54AM +, Simon Ser wrote: > On Tuesday, November 9th, 2021 at 10:24, Daniel Vetter > wrote: > > > On Tue, Nov 09, 2021 at 08:56:10AM +, Simon Ser wrote: > > > There are a few details specific to the GETFB2 IOCTL. > > > > > > It's not immediately clear how use

Re: [PATCH] drm: document DRM_IOCTL_MODE_GETFB2

2021-11-09 Thread Simon Ser
On Tuesday, November 9th, 2021 at 10:24, Daniel Vetter wrote: > On Tue, Nov 09, 2021 at 08:56:10AM +, Simon Ser wrote: > > There are a few details specific to the GETFB2 IOCTL. > > > > It's not immediately clear how user-space should check for the > > number of planes. Suggest using the pitch

Re: [PATCH] drm: document DRM_IOCTL_MODE_GETFB2

2021-11-09 Thread Daniel Vetter
On Tue, Nov 09, 2021 at 08:56:10AM +, Simon Ser wrote: > There are a few details specific to the GETFB2 IOCTL. > > It's not immediately clear how user-space should check for the > number of planes. Suggest using the pitches field. > > The modifier array is filled with zeroes, ie. DRM_FORMAT_M

[PATCH] drm: document DRM_IOCTL_MODE_GETFB2

2021-11-09 Thread Simon Ser
There are a few details specific to the GETFB2 IOCTL. It's not immediately clear how user-space should check for the number of planes. Suggest using the pitches field. The modifier array is filled with zeroes, ie. DRM_FORMAT_MOD_LINEAR. So explicitly tell user-space to not look at it unless the f