[PATCH] drm: do not use device name as a format string

2015-12-07 Thread Nicolas Iooss
On 12/07/2015 01:31 PM, Thierry Reding wrote: > On Mon, Dec 07, 2015 at 12:46:52PM +0100, Daniel Vetter wrote: >> On Mon, Dec 07, 2015 at 11:53:01AM +0200, Jani Nikula wrote: >>> On Mon, 07 Dec 2015, Daniel Vetter wrote: On Sun, Dec 06, 2015 at 11:16:32AM +0100, Nicolas Iooss wrote: > On

[PATCH] drm: do not use device name as a format string

2015-12-07 Thread Thierry Reding
On Mon, Dec 07, 2015 at 12:46:52PM +0100, Daniel Vetter wrote: > On Mon, Dec 07, 2015 at 11:53:01AM +0200, Jani Nikula wrote: > > On Mon, 07 Dec 2015, Daniel Vetter wrote: > > > On Sun, Dec 06, 2015 at 11:16:32AM +0100, Nicolas Iooss wrote: > > >> On 12/06/2015 10:35 AM, Daniel Vetter wrote: > > >

[PATCH] drm: do not use device name as a format string

2015-12-07 Thread Boris Brezillon
On Wed, 18 Nov 2015 18:58:18 +0100 Nicolas Iooss wrote: > drm_dev_set_unique() formats its parameter using kvasprintf() but many > of its callers directly pass dev_name(dev) as printf format string, > without any format parameter. This can cause some issues when the > device name contains '%' ch

[PATCH] drm: do not use device name as a format string

2015-12-07 Thread Daniel Vetter
On Mon, Dec 07, 2015 at 11:53:01AM +0200, Jani Nikula wrote: > On Mon, 07 Dec 2015, Daniel Vetter wrote: > > On Sun, Dec 06, 2015 at 11:16:32AM +0100, Nicolas Iooss wrote: > >> On 12/06/2015 10:35 AM, Daniel Vetter wrote: > >> >> On 11/18/2015 06:58 PM, Nicolas Iooss wrote: > >> >>> drm_dev_set_un

[PATCH] drm: do not use device name as a format string

2015-12-07 Thread Jani Nikula
On Mon, 07 Dec 2015, Daniel Vetter wrote: > On Sun, Dec 06, 2015 at 11:16:32AM +0100, Nicolas Iooss wrote: >> On 12/06/2015 10:35 AM, Daniel Vetter wrote: >> >> On 11/18/2015 06:58 PM, Nicolas Iooss wrote: >> >>> drm_dev_set_unique() formats its parameter using kvasprintf() but many >> >>> of its

[PATCH] drm: do not use device name as a format string

2015-12-07 Thread Daniel Vetter
On Sun, Dec 06, 2015 at 11:16:32AM +0100, Nicolas Iooss wrote: > On 12/06/2015 10:35 AM, Daniel Vetter wrote: > >> On 11/18/2015 06:58 PM, Nicolas Iooss wrote: > >>> drm_dev_set_unique() formats its parameter using kvasprintf() but many > >>> of its callers directly pass dev_name(dev) as printf for

[PATCH] drm: do not use device name as a format string

2015-12-06 Thread Nicolas Iooss
On 12/06/2015 10:35 AM, Daniel Vetter wrote: >> On 11/18/2015 06:58 PM, Nicolas Iooss wrote: >>> drm_dev_set_unique() formats its parameter using kvasprintf() but many >>> of its callers directly pass dev_name(dev) as printf format string, >>> without any format parameter. This can cause some issu

[PATCH] drm: do not use device name as a format string

2015-12-06 Thread Daniel Vetter
On Sat, Dec 05, 2015 at 10:45:50AM +0100, Nicolas Iooss wrote: > Hello, > I sent the path below a few weeks ago and did not have any feedback. > Is there any issue in it that I need to fix before submitting it again? Sorry, must have missed this. > > Thanks, > Nicolas Iooss > > On 11/18/2015 06

[PATCH] drm: do not use device name as a format string

2015-12-05 Thread Nicolas Iooss
Hello, I sent the path below a few weeks ago and did not have any feedback. Is there any issue in it that I need to fix before submitting it again? Thanks, Nicolas Iooss On 11/18/2015 06:58 PM, Nicolas Iooss wrote: > drm_dev_set_unique() formats its parameter using kvasprintf() but many > of its

[PATCH] drm: do not use device name as a format string

2015-11-18 Thread Nicolas Iooss
drm_dev_set_unique() formats its parameter using kvasprintf() but many of its callers directly pass dev_name(dev) as printf format string, without any format parameter. This can cause some issues when the device name contains '%' characters. To avoid any potential issue, always use "%s" when usin