[PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Daniel Vetter
On Fri, Sep 28, 2012 at 3:36 PM, Alex Deucher wrote: > Thinking about modern hw, I'd probably only expose connectors and > monitors (or maybe call them displays). You could hang backlight > controls and brightness, etc on the monitor objects. Also you could > have a multiple monitors connected t

[PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Ville Syrjälä
On Fri, Sep 28, 2012 at 01:55:19PM +0200, Daniel Vetter wrote: > On Fri, Sep 28, 2012 at 12:54 PM, Rob Clark wrote: > > Maybe it just makes sense to always do connector->dpms(OFF) before > > unhooking the chain, rather than directly calling dpms on the > > encoder/crtc? > > Well, that makes the e

[PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Rob Clark
On Fri, Sep 28, 2012 at 2:52 PM, Alan Cox wrote: > On Fri, 28 Sep 2012 09:27:18 +0200 > Rob Clark wrote: > >> From: Rob Clark >> >> When disabling unused connectors, be sure to call connector->dpms(OFF), >> so if there is actually some IP to turn off (such as external bridge >> chips, etc), thes

[PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Rob Clark
On Fri, Sep 28, 2012 at 1:55 PM, Daniel Vetter wrote: > On Fri, Sep 28, 2012 at 12:54 PM, Rob Clark wrote: >> Maybe it just makes sense to always do connector->dpms(OFF) before >> unhooking the chain, rather than directly calling dpms on the >> encoder/crtc? > > Well, that makes the entire (optio

[PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Daniel Vetter
On Fri, Sep 28, 2012 at 12:54 PM, Rob Clark wrote: > Maybe it just makes sense to always do connector->dpms(OFF) before > unhooking the chain, rather than directly calling dpms on the > encoder/crtc? Well, that makes the entire (optional) ->disable stuff a bit more awkward. The thing imo really i

[PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Alan Cox
On Fri, 28 Sep 2012 09:27:18 +0200 Rob Clark wrote: > From: Rob Clark > > When disabling unused connectors, be sure to call connector->dpms(OFF), > so if there is actually some IP to turn off (such as external bridge > chips, etc), these actually do get turned off. That's a fairly drastic and

[PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Rob Clark
On Fri, Sep 28, 2012 at 11:56 AM, Daniel Vetter wrote: > On Fri, Sep 28, 2012 at 09:27:18AM +0200, Rob Clark wrote: >> From: Rob Clark >> >> When disabling unused connectors, be sure to call connector->dpms(OFF), >> so if there is actually some IP to turn off (such as external bridge >> chips, et

[PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Daniel Vetter
On Fri, Sep 28, 2012 at 09:27:18AM +0200, Rob Clark wrote: > From: Rob Clark > > When disabling unused connectors, be sure to call connector->dpms(OFF), > so if there is actually some IP to turn off (such as external bridge > chips, etc), these actually do get turned off. > > Signed-off-by: Rob

[PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Alex Deucher
On Fri, Sep 28, 2012 at 8:19 AM, Rob Clark wrote: > On Fri, Sep 28, 2012 at 1:55 PM, Daniel Vetter wrote: >> On Fri, Sep 28, 2012 at 12:54 PM, Rob Clark wrote: >>> Maybe it just makes sense to always do connector->dpms(OFF) before >>> unhooking the chain, rather than directly calling dpms on the

[PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Rob Clark
From: Rob Clark When disabling unused connectors, be sure to call connector->dpms(OFF), so if there is actually some IP to turn off (such as external bridge chips, etc), these actually do get turned off. Signed-off-by: Rob Clark Tested-by: Roger Quadros --- drivers/gpu/drm/drm_crtc_helper.c

Re: [PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Daniel Vetter
On Fri, Sep 28, 2012 at 3:36 PM, Alex Deucher wrote: > Thinking about modern hw, I'd probably only expose connectors and > monitors (or maybe call them displays). You could hang backlight > controls and brightness, etc on the monitor objects. Also you could > have a multiple monitors connected t

Re: [PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Alex Deucher
On Fri, Sep 28, 2012 at 8:19 AM, Rob Clark wrote: > On Fri, Sep 28, 2012 at 1:55 PM, Daniel Vetter wrote: >> On Fri, Sep 28, 2012 at 12:54 PM, Rob Clark wrote: >>> Maybe it just makes sense to always do connector->dpms(OFF) before >>> unhooking the chain, rather than directly calling dpms on the

Re: [PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Rob Clark
On Fri, Sep 28, 2012 at 2:52 PM, Alan Cox wrote: > On Fri, 28 Sep 2012 09:27:18 +0200 > Rob Clark wrote: > >> From: Rob Clark >> >> When disabling unused connectors, be sure to call connector->dpms(OFF), >> so if there is actually some IP to turn off (such as external bridge >> chips, etc), thes

Re: [PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Alan Cox
On Fri, 28 Sep 2012 09:27:18 +0200 Rob Clark wrote: > From: Rob Clark > > When disabling unused connectors, be sure to call connector->dpms(OFF), > so if there is actually some IP to turn off (such as external bridge > chips, etc), these actually do get turned off. That's a fairly drastic and

Re: [PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Rob Clark
On Fri, Sep 28, 2012 at 1:55 PM, Daniel Vetter wrote: > On Fri, Sep 28, 2012 at 12:54 PM, Rob Clark wrote: >> Maybe it just makes sense to always do connector->dpms(OFF) before >> unhooking the chain, rather than directly calling dpms on the >> encoder/crtc? > > Well, that makes the entire (optio

Re: [PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Ville Syrjälä
On Fri, Sep 28, 2012 at 01:55:19PM +0200, Daniel Vetter wrote: > On Fri, Sep 28, 2012 at 12:54 PM, Rob Clark wrote: > > Maybe it just makes sense to always do connector->dpms(OFF) before > > unhooking the chain, rather than directly calling dpms on the > > encoder/crtc? > > Well, that makes the e

Re: [PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Daniel Vetter
On Fri, Sep 28, 2012 at 12:54 PM, Rob Clark wrote: > Maybe it just makes sense to always do connector->dpms(OFF) before > unhooking the chain, rather than directly calling dpms on the > encoder/crtc? Well, that makes the entire (optional) ->disable stuff a bit more awkward. The thing imo really i

Re: [PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Rob Clark
On Fri, Sep 28, 2012 at 11:56 AM, Daniel Vetter wrote: > On Fri, Sep 28, 2012 at 09:27:18AM +0200, Rob Clark wrote: >> From: Rob Clark >> >> When disabling unused connectors, be sure to call connector->dpms(OFF), >> so if there is actually some IP to turn off (such as external bridge >> chips, et

Re: [PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Daniel Vetter
On Fri, Sep 28, 2012 at 09:27:18AM +0200, Rob Clark wrote: > From: Rob Clark > > When disabling unused connectors, be sure to call connector->dpms(OFF), > so if there is actually some IP to turn off (such as external bridge > chips, etc), these actually do get turned off. > > Signed-off-by: Rob

[PATCH] drm: call connector->dpms(OFF) when disabling

2012-09-28 Thread Rob Clark
From: Rob Clark When disabling unused connectors, be sure to call connector->dpms(OFF), so if there is actually some IP to turn off (such as external bridge chips, etc), these actually do get turned off. Signed-off-by: Rob Clark Tested-by: Roger Quadros --- drivers/gpu/drm/drm_crtc_helper.c