Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

2021-05-29 Thread yukuai (C)
ping ... On 2021/05/18 20:58, Robert Foss wrote: On Tue, 18 May 2021 at 09:42, Johan Hovold wrote: On Mon, May 17, 2021 at 11:27:38AM +0200, Robert Foss wrote: Hey Yu, On Mon, 17 May 2021 at 10:08, Yu Kuai wrote: pm_runtime_get_sync will increment pm usage counter even it failed. Forgett

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

2021-05-18 Thread Robert Foss
On Tue, 18 May 2021 at 09:42, Johan Hovold wrote: > > On Mon, May 17, 2021 at 11:27:38AM +0200, Robert Foss wrote: > > Hey Yu, > > > > On Mon, 17 May 2021 at 10:08, Yu Kuai wrote: > > > > > > pm_runtime_get_sync will increment pm usage counter even it failed. > > > Forgetting to putting operation

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

2021-05-18 Thread Johan Hovold
On Mon, May 17, 2021 at 11:27:38AM +0200, Robert Foss wrote: > Hey Yu, > > On Mon, 17 May 2021 at 10:08, Yu Kuai wrote: > > > > pm_runtime_get_sync will increment pm usage counter even it failed. > > Forgetting to putting operation will result in reference leak here. > > Fix it by replacing it wi

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

2021-05-17 Thread yukuai (C)
On 2021/05/17 17:27, Robert Foss wrote: Hey Yu, On Mon, 17 May 2021 at 10:08, Yu Kuai wrote: pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep us

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

2021-05-17 Thread Robert Foss
Hey Yu, On Mon, 17 May 2021 at 10:08, Yu Kuai wrote: > > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. > > Reported

[PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

2021-05-17 Thread Yu Kuai
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Yu Kuai --- drivers/gpu/drm/bridge