Re: [PATCH] drm: bridge: Constify mode arguments to bridge .mode_set() operation

2018-04-13 Thread Daniel Vetter
On Mon, Apr 09, 2018 at 12:43:07PM +0300, Laurent Pinchart wrote: > Hi Daniel, > > On Monday, 9 April 2018 12:18:28 EEST Daniel Vetter wrote: > > On Mon, Apr 09, 2018 at 11:56:55AM +0300, Laurent Pinchart wrote: > > > On Monday, 9 April 2018 11:53:07 EEST Daniel Vetter wrote: > > >> On Fri, Apr 06

Re: [PATCH] drm: bridge: Constify mode arguments to bridge .mode_set() operation

2018-04-09 Thread Laurent Pinchart
Hi Daniel, On Monday, 9 April 2018 12:18:28 EEST Daniel Vetter wrote: > On Mon, Apr 09, 2018 at 11:56:55AM +0300, Laurent Pinchart wrote: > > On Monday, 9 April 2018 11:53:07 EEST Daniel Vetter wrote: > >> On Fri, Apr 06, 2018 at 07:23:57PM +0300, Laurent Pinchart wrote: > >>> The mode and ajusted

Re: [PATCH] drm: bridge: Constify mode arguments to bridge .mode_set() operation

2018-04-09 Thread Daniel Vetter
On Mon, Apr 09, 2018 at 11:56:55AM +0300, Laurent Pinchart wrote: > On Monday, 9 April 2018 11:53:07 EEST Daniel Vetter wrote: > > On Fri, Apr 06, 2018 at 07:23:57PM +0300, Laurent Pinchart wrote: > > > The mode and ajusted_mode passed to the bridge .mode_set() operation > > > should never be modif

Re: [PATCH] drm: bridge: Constify mode arguments to bridge .mode_set() operation

2018-04-09 Thread Laurent Pinchart
On Monday, 9 April 2018 11:53:07 EEST Daniel Vetter wrote: > On Fri, Apr 06, 2018 at 07:23:57PM +0300, Laurent Pinchart wrote: > > The mode and ajusted_mode passed to the bridge .mode_set() operation > > should never be modified by the bridge (and are not in any of the > > existing bridge drivers).

Re: [PATCH] drm: bridge: Constify mode arguments to bridge .mode_set() operation

2018-04-09 Thread Daniel Vetter
On Fri, Apr 06, 2018 at 07:23:57PM +0300, Laurent Pinchart wrote: > The mode and ajusted_mode passed to the bridge .mode_set() operation > should never be modified by the bridge (and are not in any of the > existing bridge drivers). Make them const to make this clear. > > Signed-off-by: Laurent Pi

[PATCH] drm: bridge: Constify mode arguments to bridge .mode_set() operation

2018-04-06 Thread Laurent Pinchart
The mode and ajusted_mode passed to the bridge .mode_set() operation should never be modified by the bridge (and are not in any of the existing bridge drivers). Make them const to make this clear. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 4 ++-- d